[PATCH] arm/omap4: add twd clock to DT

[PATCH] arm/omap4: add twd clock to DT

[Gilles Chanteperdrix]

Booting Linux 3.14 on Pandaboard currently gets the following
message displayed:

smp_twd: clock not found -2

Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.

Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
---
 arch/arm/boot/dts/omap4.dtsi |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index d3f8a6e..a7f1d3a 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -62,6 +62,7 @@
 
 	local-timer at 48240600 {
 		compatible = "arm,cortex-a9-twd-timer";
+		clocks = <&mpu_periphclk>;
 		reg = <0x48240600 0x20>;
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_HIGH)>;
 	};
-- 
1.7.10.4

[PATCH] arm/omap4: add twd clock to DT

[Tony Lindgren]

* Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
> Booting Linux 3.14 on Pandaboard currently gets the following
> message displayed:
> 
> smp_twd: clock not found -2
> 
> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.

Tero, care to ack?

Tony
 
> Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
> ---
>  arch/arm/boot/dts/omap4.dtsi |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index d3f8a6e..a7f1d3a 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -62,6 +62,7 @@
>  
>  	local-timer at 48240600 {
>  		compatible = "arm,cortex-a9-twd-timer";
> +		clocks = <&mpu_periphclk>;
>  		reg = <0x48240600 0x20>;
>  		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_HIGH)>;
>  	};
> -- 
> 1.7.10.4
> 

[PATCH] arm/omap4: add twd clock to DT

[Gilles Chanteperdrix]

Le 19/04/2014 00:39, Tony Lindgren a ?crit :
> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
>> Booting Linux 3.14 on Pandaboard currently gets the following
>> message displayed:
>>
>> smp_twd: clock not found -2
>>
>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
> 
> Tero, care to ack?

Sorry if I did not mail the right people, get_maintainer.pl gave me a
long list, and I did not feel like spamming all these people for such a
small patch. I do not believe Tero was in this list.

Regards.


-- 
Gilles.

[PATCH] arm/omap4: add twd clock to DT

[Tero Kristo]

On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
> Le 19/04/2014 00:39, Tony Lindgren a ?crit :
>> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
>>> Booting Linux 3.14 on Pandaboard currently gets the following
>>> message displayed:
>>>
>>> smp_twd: clock not found -2
>>>
>>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
>>
>> Tero, care to ack?
>
> Sorry if I did not mail the right people, get_maintainer.pl gave me a
> long list, and I did not feel like spamming all these people for such a
> small patch. I do not believe Tero was in this list.
>
> Regards.

Yea I don't think this is my expertise area, however the patch looks 
good to me, so if you really need it:

Acked-by: Tero Kristo <t-kristo@ti.com>

[PATCH] arm/omap4: add twd clock to DT

[Joachim Eastwood]

On 22 April 2014 14:39, Tero Kristo <t-kristo@ti.com> wrote:
> On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
>>
>> Le 19/04/2014 00:39, Tony Lindgren a ?crit :
>>>
>>> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
>>>>
>>>> Booting Linux 3.14 on Pandaboard currently gets the following
>>>> message displayed:
>>>>
>>>> smp_twd: clock not found -2
>>>>
>>>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
>>>
>>>
>>> Tero, care to ack?
>>
>>
>> Sorry if I did not mail the right people, get_maintainer.pl gave me a
>> long list, and I did not feel like spamming all these people for such a
>> small patch. I do not believe Tero was in this list.
>>
>> Regards.
>
>
> Yea I don't think this is my expertise area, however the patch looks good to
> me, so if you really need it:
>
> Acked-by: Tero Kristo <t-kristo@ti.com>

Tony, care to add this to your omap 3.16 dt branch?

I am still getting:
[ 0.000152] smp_twd: clock not found -2

So this fix from Gilles would be nice to have.

regards
Joachim Eastwood

[PATCH] arm/omap4: add twd clock to DT

[Tony Lindgren]

* Joachim Eastwood <manabian@gmail.com> [140518 05:08]:
> On 22 April 2014 14:39, Tero Kristo <t-kristo@ti.com> wrote:
> > On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
> >>
> >> Le 19/04/2014 00:39, Tony Lindgren a ?crit :
> >>>
> >>> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
> >>>>
> >>>> Booting Linux 3.14 on Pandaboard currently gets the following
> >>>> message displayed:
> >>>>
> >>>> smp_twd: clock not found -2
> >>>>
> >>>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
> >>>
> >>>
> >>> Tero, care to ack?
> >>
> >>
> >> Sorry if I did not mail the right people, get_maintainer.pl gave me a
> >> long list, and I did not feel like spamming all these people for such a
> >> small patch. I do not believe Tero was in this list.
> >>
> >> Regards.
> >
> >
> > Yea I don't think this is my expertise area, however the patch looks good to
> > me, so if you really need it:
> >
> > Acked-by: Tero Kristo <t-kristo@ti.com>
> 
> Tony, care to add this to your omap 3.16 dt branch?
> 
> I am still getting:
> [ 0.000152] smp_twd: clock not found -2
> 
> So this fix from Gilles would be nice to have.

Best that Tero picks this one up along with the other dt clock changes
he's queueing.

Regards,

Tony

[PATCH] arm/omap4: add twd clock to DT

[Joachim Eastwood]

On 19 May 2014 18:13, Tony Lindgren <tony@atomide.com> wrote:
> * Joachim Eastwood <manabian@gmail.com> [140518 05:08]:
>> On 22 April 2014 14:39, Tero Kristo <t-kristo@ti.com> wrote:
>> > On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
>> >>
>> >> Le 19/04/2014 00:39, Tony Lindgren a ?crit :
>> >>>
>> >>> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
>> >>>>
>> >>>> Booting Linux 3.14 on Pandaboard currently gets the following
>> >>>> message displayed:
>> >>>>
>> >>>> smp_twd: clock not found -2
>> >>>>
>> >>>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
>> >>>
>> >>>
>> >>> Tero, care to ack?
>> >>
>> >>
>> >> Sorry if I did not mail the right people, get_maintainer.pl gave me a
>> >> long list, and I did not feel like spamming all these people for such a
>> >> small patch. I do not believe Tero was in this list.
>> >>
>> >> Regards.
>> >
>> >
>> > Yea I don't think this is my expertise area, however the patch looks good to
>> > me, so if you really need it:
>> >
>> > Acked-by: Tero Kristo <t-kristo@ti.com>
>>
>> Tony, care to add this to your omap 3.16 dt branch?
>>
>> I am still getting:
>> [ 0.000152] smp_twd: clock not found -2
>>
>> So this fix from Gilles would be nice to have.
>
> Best that Tero picks this one up along with the other dt clock changes
> he's queueing.

I kinda assumed you would take it since you asked Tero to ack it. But
either way is fine :)
Thanks.

regards
Joachim Eastwood

[PATCH] arm/omap4: add twd clock to DT

[Tony Lindgren]

* Joachim Eastwood <manabian@gmail.com> [140519 09:24]:
> On 19 May 2014 18:13, Tony Lindgren <tony@atomide.com> wrote:
> > * Joachim Eastwood <manabian@gmail.com> [140518 05:08]:
> >> On 22 April 2014 14:39, Tero Kristo <t-kristo@ti.com> wrote:
> >> > On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
> >> >>
> >> >> Le 19/04/2014 00:39, Tony Lindgren a ?crit :
> >> >>>
> >> >>> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
> >> >>>>
> >> >>>> Booting Linux 3.14 on Pandaboard currently gets the following
> >> >>>> message displayed:
> >> >>>>
> >> >>>> smp_twd: clock not found -2
> >> >>>>
> >> >>>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
> >> >>>
> >> >>>
> >> >>> Tero, care to ack?
> >> >>
> >> >>
> >> >> Sorry if I did not mail the right people, get_maintainer.pl gave me a
> >> >> long list, and I did not feel like spamming all these people for such a
> >> >> small patch. I do not believe Tero was in this list.
> >> >>
> >> >> Regards.
> >> >
> >> >
> >> > Yea I don't think this is my expertise area, however the patch looks good to
> >> > me, so if you really need it:
> >> >
> >> > Acked-by: Tero Kristo <t-kristo@ti.com>
> >>
> >> Tony, care to add this to your omap 3.16 dt branch?
> >>
> >> I am still getting:
> >> [ 0.000152] smp_twd: clock not found -2
> >>
> >> So this fix from Gilles would be nice to have.
> >
> > Best that Tero picks this one up along with the other dt clock changes
> > he's queueing.
> 
> I kinda assumed you would take it since you asked Tero to ack it. But
> either way is fine :)

Yes that was before Tero started collecting the dt clock patches :)

Regards,

Tony

[PATCH] arm/omap4: add twd clock to DT

[Tero Kristo]

On 05/19/2014 07:27 PM, Tony Lindgren wrote:
> * Joachim Eastwood <manabian@gmail.com> [140519 09:24]:
>> On 19 May 2014 18:13, Tony Lindgren <tony@atomide.com> wrote:
>>> * Joachim Eastwood <manabian@gmail.com> [140518 05:08]:
>>>> On 22 April 2014 14:39, Tero Kristo <t-kristo@ti.com> wrote:
>>>>> On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
>>>>>>
>>>>>> Le 19/04/2014 00:39, Tony Lindgren a ?crit :
>>>>>>>
>>>>>>> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
>>>>>>>>
>>>>>>>> Booting Linux 3.14 on Pandaboard currently gets the following
>>>>>>>> message displayed:
>>>>>>>>
>>>>>>>> smp_twd: clock not found -2
>>>>>>>>
>>>>>>>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
>>>>>>>
>>>>>>>
>>>>>>> Tero, care to ack?
>>>>>>
>>>>>>
>>>>>> Sorry if I did not mail the right people, get_maintainer.pl gave me a
>>>>>> long list, and I did not feel like spamming all these people for such a
>>>>>> small patch. I do not believe Tero was in this list.
>>>>>>
>>>>>> Regards.
>>>>>
>>>>>
>>>>> Yea I don't think this is my expertise area, however the patch looks good to
>>>>> me, so if you really need it:
>>>>>
>>>>> Acked-by: Tero Kristo <t-kristo@ti.com>
>>>>
>>>> Tony, care to add this to your omap 3.16 dt branch?
>>>>
>>>> I am still getting:
>>>> [ 0.000152] smp_twd: clock not found -2
>>>>
>>>> So this fix from Gilles would be nice to have.
>>>
>>> Best that Tero picks this one up along with the other dt clock changes
>>> he's queueing.
>>
>> I kinda assumed you would take it since you asked Tero to ack it. But
>> either way is fine :)
>
> Yes that was before Tero started collecting the dt clock patches :)

I wouldn't say this to be a clock patch as such, this touches the driver 
behavior, i.e. registers the correct clock for the driver. That being 
said, I can still queue this up with the clock patches if that is what 
you want.

-Tero

[PATCH] arm/omap4: add twd clock to DT

[Tony Lindgren]

* Tero Kristo <t-kristo@ti.com> [140520 02:01]:
> On 05/19/2014 07:27 PM, Tony Lindgren wrote:
> >* Joachim Eastwood <manabian@gmail.com> [140519 09:24]:
> >>On 19 May 2014 18:13, Tony Lindgren <tony@atomide.com> wrote:
> >>>* Joachim Eastwood <manabian@gmail.com> [140518 05:08]:
> >>>>On 22 April 2014 14:39, Tero Kristo <t-kristo@ti.com> wrote:
> >>>>>On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
> >>>>>>
> >>>>>>Le 19/04/2014 00:39, Tony Lindgren a ?crit :
> >>>>>>>
> >>>>>>>* Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
> >>>>>>>>
> >>>>>>>>Booting Linux 3.14 on Pandaboard currently gets the following
> >>>>>>>>message displayed:
> >>>>>>>>
> >>>>>>>>smp_twd: clock not found -2
> >>>>>>>>
> >>>>>>>>Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
> >>>>>>>
> >>>>>>>
> >>>>>>>Tero, care to ack?
> >>>>>>
> >>>>>>
> >>>>>>Sorry if I did not mail the right people, get_maintainer.pl gave me a
> >>>>>>long list, and I did not feel like spamming all these people for such a
> >>>>>>small patch. I do not believe Tero was in this list.
> >>>>>>
> >>>>>>Regards.
> >>>>>
> >>>>>
> >>>>>Yea I don't think this is my expertise area, however the patch looks good to
> >>>>>me, so if you really need it:
> >>>>>
> >>>>>Acked-by: Tero Kristo <t-kristo@ti.com>
> >>>>
> >>>>Tony, care to add this to your omap 3.16 dt branch?
> >>>>
> >>>>I am still getting:
> >>>>[ 0.000152] smp_twd: clock not found -2
> >>>>
> >>>>So this fix from Gilles would be nice to have.
> >>>
> >>>Best that Tero picks this one up along with the other dt clock changes
> >>>he's queueing.
> >>
> >>I kinda assumed you would take it since you asked Tero to ack it. But
> >>either way is fine :)
> >
> >Yes that was before Tero started collecting the dt clock patches :)
> 
> I wouldn't say this to be a clock patch as such, this touches the driver
> behavior, i.e. registers the correct clock for the driver. That being said,
> I can still queue this up with the clock patches if that is what you want.

Yes please go ahead and take this one.

Thanks,

Tony

[PATCH] arm/omap4: add twd clock to DT

[Tero Kristo]

On 05/20/2014 05:49 PM, Tony Lindgren wrote:
> * Tero Kristo <t-kristo@ti.com> [140520 02:01]:
>> On 05/19/2014 07:27 PM, Tony Lindgren wrote:
>>> * Joachim Eastwood <manabian@gmail.com> [140519 09:24]:
>>>> On 19 May 2014 18:13, Tony Lindgren <tony@atomide.com> wrote:
>>>>> * Joachim Eastwood <manabian@gmail.com> [140518 05:08]:
>>>>>> On 22 April 2014 14:39, Tero Kristo <t-kristo@ti.com> wrote:
>>>>>>> On 04/20/2014 07:22 PM, Gilles Chanteperdrix wrote:
>>>>>>>>
>>>>>>>> Le 19/04/2014 00:39, Tony Lindgren a ?crit :
>>>>>>>>>
>>>>>>>>> * Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> [140407 13:09]:
>>>>>>>>>>
>>>>>>>>>> Booting Linux 3.14 on Pandaboard currently gets the following
>>>>>>>>>> message displayed:
>>>>>>>>>>
>>>>>>>>>> smp_twd: clock not found -2
>>>>>>>>>>
>>>>>>>>>> Define "mpu_periphclk" as the twd clock in omap4 dts to avoid this.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Tero, care to ack?
>>>>>>>>
>>>>>>>>
>>>>>>>> Sorry if I did not mail the right people, get_maintainer.pl gave me a
>>>>>>>> long list, and I did not feel like spamming all these people for such a
>>>>>>>> small patch. I do not believe Tero was in this list.
>>>>>>>>
>>>>>>>> Regards.
>>>>>>>
>>>>>>>
>>>>>>> Yea I don't think this is my expertise area, however the patch looks good to
>>>>>>> me, so if you really need it:
>>>>>>>
>>>>>>> Acked-by: Tero Kristo <t-kristo@ti.com>
>>>>>>
>>>>>> Tony, care to add this to your omap 3.16 dt branch?
>>>>>>
>>>>>> I am still getting:
>>>>>> [ 0.000152] smp_twd: clock not found -2
>>>>>>
>>>>>> So this fix from Gilles would be nice to have.
>>>>>
>>>>> Best that Tero picks this one up along with the other dt clock changes
>>>>> he's queueing.
>>>>
>>>> I kinda assumed you would take it since you asked Tero to ack it. But
>>>> either way is fine :)
>>>
>>> Yes that was before Tero started collecting the dt clock patches :)
>>
>> I wouldn't say this to be a clock patch as such, this touches the driver
>> behavior, i.e. registers the correct clock for the driver. That being said,
>> I can still queue this up with the clock patches if that is what you want.
>
> Yes please go ahead and take this one.
>
> Thanks,
>
> Tony
>

Ok, thanks, queued for 3.16.

-Tero