public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: nomadik: Fixup system suspend
Date: Wed, 21 May 2014 10:33:44 +0200	[thread overview]
Message-ID: <20140521083344.GH2708@katana> (raw)
In-Reply-To: <1397138376-28427-1-git-send-email-ulf.hansson@linaro.org>

On Thu, Apr 10, 2014 at 03:59:36PM +0200, Ulf Hansson wrote:
> For !CONFIG_PM_RUNTIME, the device were never put back into active
> state while resuming.
> 
> For CONFIG_PM_RUNTIME, we blindly trusted the device to be inactive
> while we were about to handle it at suspend late, which is just too
> optimistic.
> 
> Even if the driver uses pm_runtime_put_sync() after each tranfer to
> return it's runtime PM resources, there are no guarantees this will
> actually mean the device will inactivated. The reason is that the PM
> core will prevent runtime suspend during system suspend, and thus when
> a transfer occurs during the early phases of system suspend the device
> will be kept active after the transfer.
> 
> To handle both issues above, use pm_runtime_force_suspend|resume() from
> the system suspend|resume callbacks.
> 
> Cc: Alessandro Rubini <rubini@unipv.it>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140521/f8b2b043/attachment.sig>

      parent reply	other threads:[~2014-05-21  8:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 13:59 [PATCH] i2c: nomadik: Fixup system suspend Ulf Hansson
2014-04-10 18:49 ` Linus Walleij
2014-05-06  9:31   ` Ulf Hansson
2014-05-15  7:15     ` Ulf Hansson
2014-05-15  7:48       ` Wolfram Sang
2014-05-15 15:36         ` Ulf Hansson
2014-05-21  8:33 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521083344.GH2708@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox