From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] documentation/devicetree: Update GIC compat strings
Date: Wed, 21 May 2014 11:24:39 +0100 [thread overview]
Message-ID: <20140521102439.GE17827@leverpostej> (raw)
In-Reply-To: <1400664501-4208-3-git-send-email-Nikolay.Borisov@arm.com>
[Adding devicetree at vger.kernel.org]
On Wed, May 21, 2014 at 10:28:21AM +0100, Nikolay Borisov wrote:
> Document the addition of 2 new, implementation-agnostic compatible
> strings. This allows for more flexibility such that new implementation
> can either state whether they are an extension of an existing implementation,
> a brand new implementation or just that they conform to a standard revision
> of the GIC spec.
>From my POV it makes sense to have these to make it possible to write
DTs with new GIC variants which are implementations of the standard
rather than extensions of existing implementations.
However, DTs using these should also state exactly what variant they
are, and those strings should be documented (even if not supported
directly by the driver). It would be nice to have that mentioned in the
commit message.
Otherwise:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Cheers,
Mark.
>
> Signed-off-by: Nikolay Borisov <Nikolay.Borisov@arm.com>
> ---
> Documentation/devicetree/bindings/arm/gic.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/gic.txt b/Documentation/devicetree/bindings/arm/gic.txt
> index 5573c08..223b4cc 100644
> --- a/Documentation/devicetree/bindings/arm/gic.txt
> +++ b/Documentation/devicetree/bindings/arm/gic.txt
> @@ -12,6 +12,8 @@ Main node required properties:
>
> - compatible : should be one of:
> "arm,gic-400"
> + "arm,gic-v1"
> + "arm,gic-v2"
> "arm,cortex-a15-gic"
> "arm,cortex-a9-gic"
> "arm,cortex-a7-gic"
> --
> 1.8.1.5
>
next prev parent reply other threads:[~2014-05-21 10:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 9:28 [PATCH 0/2] Add generic GIC compat strings Nikolay Borisov
2014-05-21 9:28 ` [PATCH 1/2] irqchip: Add generic gic-v1/gic-v2 " Nikolay Borisov
2014-05-21 10:27 ` Mark Rutland
2014-05-21 9:28 ` [PATCH 2/2] documentation/devicetree: Update GIC " Nikolay Borisov
2014-05-21 10:24 ` Mark Rutland [this message]
2014-05-21 13:01 ` Jason Cooper
-- strict thread matches above, loose matches on Subject: below --
2014-05-21 13:48 [PATCH RESEND 0/2] Add generic " Nikolay Borisov
2014-05-21 13:48 ` [PATCH 2/2] documentation/devicetree: Update " Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521102439.GE17827@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox