public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL 4/5] Samsung DT updates for 3.16
Date: Wed, 21 May 2014 22:45:47 -0700	[thread overview]
Message-ID: <20140522054547.GA4021@quad.lixom.net> (raw)
In-Reply-To: <014701cf73c8$752a65c0$5f7f3140$@samsung.com>

On Tue, May 20, 2014 at 10:11:41AM +0900, Kukjin Kim wrote:

> Sachin Kamat (4):
>       ARM: EXYNOS: Map SYSRAM through generic DT bindings

This patch has a conflict with your own fixes. You should have based this
branch on top of the fixes to avoid it.

Not only that, but it seems to break 4212, which the other fix was meant to
take care of.

I think I've fixed it in my merge, please double check. You really have to
be more careful than this in the future.

My resolution is:

index aa01c4222b40,483dfcd69065..000000000000
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@@ -18,8 -18,7 +18,9 @@@
  
  #include <mach/map.h>
  
 +#include <plat/cpu.h>
 +
+ #include "common.h"
  #include "smc.h"
  
  static int exynos_do_idle(void)
@@@ -44,10 -35,12 +45,15 @@@ static int exynos_cpu_boot(int cpu
  
  static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
  {
-       void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c;
+       void __iomem *boot_reg;
+ 
+       if (!sysram_ns_base_addr)
+               return -ENODEV;
+ 
 -      boot_reg = sysram_ns_base_addr + 0x1c + 4*cpu;
++      boot_reg = sysram_ns_base_addr + 0x1c;
 +
 +      if (!soc_is_exynos4212())
 +              boot_reg += 4*cpu;
  


-Olof

  parent reply	other threads:[~2014-05-22  5:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  1:11 [GIT PULL 4/5] Samsung DT updates for 3.16 Kukjin Kim
2014-05-22  5:38 ` Olof Johansson
2014-05-22  5:45 ` Olof Johansson [this message]
2014-05-22 11:36   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522054547.GA4021@quad.lixom.net \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox