linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: socfpga: dts: add watchdog0+1
@ 2014-05-22 10:19 Steffen Trumtrar
  2014-05-22 12:46 ` Sergei Shtylyov
  2014-05-22 12:48 ` Sergei Shtylyov
  0 siblings, 2 replies; 4+ messages in thread
From: Steffen Trumtrar @ 2014-05-22 10:19 UTC (permalink / raw)
  To: linux-arm-kernel

The SoCFPGA has two watchdog timers. Add them to the dtsi.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 56fc214..ee10fa6 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -549,6 +549,22 @@
 			reg = <0xffd05000 0x1000>;
 		};
 
+		watchdog0: wd at ffd02000 {
+			compatible = "snps,dw-wdt";
+			reg = <0xffd02000 0x1000>;
+			interrupts = <0 171 0>;
+			clocks = <&osc1>;
+			status = "disabled";
+		};
+
+		watchdog1: wd at ffd04000 {
+			compatible = "snps,dw-wdt";
+			reg = <0xffd03000 0x1000>;
+			interrupts = <0 172 0>;
+			clocks = <&osc1>;
+			status = "disabled";
+		};
+
 		sysmgr: sysmgr at ffd08000 {
 			compatible = "altr,sys-mgr", "syscon";
 			reg = <0xffd08000 0x4000>;
-- 
2.0.0.rc0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: socfpga: dts: add watchdog0+1
  2014-05-22 10:19 [PATCH] ARM: socfpga: dts: add watchdog0+1 Steffen Trumtrar
@ 2014-05-22 12:46 ` Sergei Shtylyov
  2014-05-22 12:48 ` Sergei Shtylyov
  1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-05-22 12:46 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 22-05-2014 14:19, Steffen Trumtrar wrote:

> The SoCFPGA has two watchdog timers. Add them to the dtsi.

> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>   arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)

> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 56fc214..ee10fa6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -549,6 +549,22 @@
>   			reg = <0xffd05000 0x1000>;
>   		};
>
> +		watchdog0: wd at ffd02000 {

    The node name should be "watchdog", according to section 2.2.2 of the 
ePPAR standard [1].


> +		watchdog1: wd at ffd04000 {

    Same here.

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: socfpga: dts: add watchdog0+1
  2014-05-22 10:19 [PATCH] ARM: socfpga: dts: add watchdog0+1 Steffen Trumtrar
  2014-05-22 12:46 ` Sergei Shtylyov
@ 2014-05-22 12:48 ` Sergei Shtylyov
  2014-05-22 12:50   ` Steffen Trumtrar
  1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2014-05-22 12:48 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 22-05-2014 14:19, Steffen Trumtrar wrote:

> The SoCFPGA has two watchdog timers. Add them to the dtsi.

> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>   arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)

> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 56fc214..ee10fa6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -549,6 +549,22 @@
[...]
> +		watchdog1: wd at ffd04000 {

    Oh, and the unit-address part of the name should match the "reg" property.

> +			compatible = "snps,dw-wdt";
> +			reg = <0xffd03000 0x1000>;
> +			interrupts = <0 172 0>;
> +			clocks = <&osc1>;
> +			status = "disabled";
> +		};
> +

WBR, Sergei

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: socfpga: dts: add watchdog0+1
  2014-05-22 12:48 ` Sergei Shtylyov
@ 2014-05-22 12:50   ` Steffen Trumtrar
  0 siblings, 0 replies; 4+ messages in thread
From: Steffen Trumtrar @ 2014-05-22 12:50 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, May 22, 2014 at 04:48:16PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-05-2014 14:19, Steffen Trumtrar wrote:
> 
> >The SoCFPGA has two watchdog timers. Add them to the dtsi.
> 
> >Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> >---
> >  arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> 
> >diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> >index 56fc214..ee10fa6 100644
> >--- a/arch/arm/boot/dts/socfpga.dtsi
> >+++ b/arch/arm/boot/dts/socfpga.dtsi
> >@@ -549,6 +549,22 @@
> [...]
> >+		watchdog1: wd at ffd04000 {
> 
>    Oh, and the unit-address part of the name should match the "reg" property.
> 

Oops. Of course.

> >+			compatible = "snps,dw-wdt";
> >+			reg = <0xffd03000 0x1000>;
> >+			interrupts = <0 172 0>;
> >+			clocks = <&osc1>;
> >+			status = "disabled";
> >+		};
> >+

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-05-22 12:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-22 10:19 [PATCH] ARM: socfpga: dts: add watchdog0+1 Steffen Trumtrar
2014-05-22 12:46 ` Sergei Shtylyov
2014-05-22 12:48 ` Sergei Shtylyov
2014-05-22 12:50   ` Steffen Trumtrar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).