linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.trumtrar@pengutronix.de (Steffen Trumtrar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: socfpga: dts: add watchdog0+1
Date: Thu, 22 May 2014 16:39:50 +0200	[thread overview]
Message-ID: <20140522143950.GL949@pengutronix.de> (raw)
In-Reply-To: <537E0B27.70305@gmail.com>

Hi Dinh!

On Thu, May 22, 2014 at 09:35:19AM -0500, Dinh Nguyen wrote:
> Hi Steffen,
> 
> On 5/22/14 8:06 AM, Steffen Trumtrar wrote:
> > The SoCFPGA has two watchdog timers. Add them to the dtsi.
> >
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > index 56fc214..7bcd458 100644
> > --- a/arch/arm/boot/dts/socfpga.dtsi
> > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > @@ -549,6 +549,22 @@
> >  			reg = <0xffd05000 0x1000>;
> >  		};
> >  
> > +		watchdog0: watchdog at ffd02000 {
> > +			compatible = "snps,dw-wdt";
> > +			reg = <0xffd02000 0x1000>;
> > +			interrupts = <0 171 0>;
> This should be IRQ_TYPE_LEVEL_HIGH.
> > +			clocks = <&osc1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		watchdog1: watchdog at ffd03000 {
> > +			compatible = "snps,dw-wdt";
> > +			reg = <0xffd03000 0x1000>;
> > +			interrupts = <0 172 0>;
> Same here..
> > +			clocks = <&osc1>;
> > +			status = "disabled";
> > +		};
> > +
> >  		sysmgr: sysmgr at ffd08000 {
> >  			compatible = "altr,sys-mgr", "syscon";
> >  			reg = <0xffd08000 0x4000>;

I wasn't aware that we started using the IRQ defines, but...

> No need to resend a patch, I'll apply with those changes.
>

...great. Thanks.

Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2014-05-22 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 13:06 [PATCH v2] ARM: socfpga: dts: add watchdog0+1 Steffen Trumtrar
2014-05-22 14:35 ` Dinh Nguyen
2014-05-22 14:39   ` Steffen Trumtrar [this message]
2014-05-22 14:50     ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522143950.GL949@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).