From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 22 May 2014 16:31:54 -0700 Subject: [PATCH 1/5] [RFC-HACK] pinctrl-single: init by postcore_initcall() In-Reply-To: <1400799986-20043-2-git-send-email-chf.fritz@googlemail.com> References: <1400799986-20043-1-git-send-email-chf.fritz@googlemail.com> <1400799986-20043-2-git-send-email-chf.fritz@googlemail.com> Message-ID: <20140522233154.GE29577@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Christoph Fritz [140522 16:07]: > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -2069,7 +2069,22 @@ static struct platform_driver pcs_driver = { > #endif > }; > > +#ifdef CONFIG_USE_OF > +static int __init pcs_driver_drv_init(void) > +{ > + return platform_driver_register(&pcs_driver); > +} > +postcore_initcall(pcs_driver_drv_init); > + > +static void __exit pcs_driver_drv_exit(void) > +{ > + platform_driver_unregister(&pcs_driver); > +} > +module_exit(pcs_driver_drv_exit); > +#else > module_platform_driver(pcs_driver); > +#endif > + I would prefer to initialize all the drivers with module_init and and if necessary, selected frameworks with subsys_initcall. In drivers/Makefile we do have painctrl before gpio, so this too could be just module_init once the other drivers are fixed. Regards, Tony