From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pwm: imx: set can_sleep flag for imx_pwm
Date: Fri, 23 May 2014 17:03:22 +0800 [thread overview]
Message-ID: <20140523090321.GA2650@dragon> (raw)
In-Reply-To: <20140523084359.GD20155@pengutronix.de>
On Fri, May 23, 2014 at 10:43:59AM +0200, Uwe Kleine-K?nig wrote:
> On Fri, May 23, 2014 at 04:41:28PM +0800, Shawn Guo wrote:
> > The .config() hook imx_pwm_config() calls clk APIs like clk_prepare()
> > and clk_get_rate(), which might sleep, so we need to set can_sleep flag
> > on pwm_chip.
> Wasn't there a bug that was fixed or at least made more obvious with
> this change? Is it worth mentioning in the commit log?
The bug should be the one same as what we fixed on pwm-mxs[1]. But I
did not try to trigger it on pwm-imx myself, because it's obvious.
Shawn
[1] http://article.gmane.org/gmane.linux.pwm/570
next prev parent reply other threads:[~2014-05-23 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 8:41 [PATCH v2] pwm: imx: set can_sleep flag for imx_pwm Shawn Guo
2014-05-23 8:43 ` Uwe Kleine-König
2014-05-23 9:03 ` Shawn Guo [this message]
2014-08-07 12:55 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523090321.GA2650@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).