From: rric@kernel.org (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 2/7] ARM: Introduce arm_get_current_stack_frame()
Date: Fri, 23 May 2014 14:11:35 +0200 [thread overview]
Message-ID: <20140523121135.GV27560@rric.localhost> (raw)
In-Reply-To: <1400837196-22339-3-git-send-email-Nikolay.Borisov@arm.com>
On 23.05.14 10:26:31, Nikolay Borisov wrote:
> +#define frame_pointer(regs) \
> + IS_ENABLED(CONFIG_THUMB2_KERNEL) ? (regs)->ARM_r7 \
> + : (regs)->ARM_fp \
#ifdef CONFIG_THUMB2_KERNEL
... is better here, this is booleon, not tristate, better to read, and
no mixed c and macro statements either.
> +void arm_get_current_stackframe(struct pt_regs *regs, struct stackframe *frame)
> +{
> + frame->fp = frame_pointer(regs);
> + frame->sp = regs->ARM_sp;
> + frame->lr = regs->ARM_lr;
> + frame->pc = regs->ARM_pc;
> +}
> +EXPORT_SYMBOL_GPL(arm_get_current_stackframe);
I am wondering if this should be better implemented as inline function
as this is in the hot path.
-Robert
next prev parent reply other threads:[~2014-05-23 12:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 9:26 [PATCH RESEND 0/7] Fix backtrace support in THUMB2 mode Nikolay Borisov
2014-05-23 9:26 ` [PATCH RESEND 1/7] ARM: Make thread_save_fp macro aware of " Nikolay Borisov
2014-05-23 9:53 ` Uwe Kleine-König
2014-05-23 11:53 ` Nikolay Borisov
2014-05-23 9:26 ` [PATCH RESEND 2/7] ARM: Introduce arm_get_current_stack_frame() Nikolay Borisov
2014-05-23 12:11 ` Robert Richter [this message]
2014-05-23 9:26 ` [PATCH RESEND 3/7] ARM: perf: Make perf use arm_get_current_stackframe Nikolay Borisov
2014-05-23 9:26 ` [PATCH RESEND 4/7] ARM: time: Make use of arm_get_current_stackframe Nikolay Borisov
2014-05-23 9:26 ` [PATCH RESEND 5/7] ARM: unwind: Use arm_get_current_stackframe Nikolay Borisov
2014-05-23 9:26 ` [PATCH RESEND 6/7] ARM: traps: Make use of the frame_pointer macro Nikolay Borisov
2014-05-23 9:26 ` [PATCH RESEND 7/7] ARM: oprofile: Use of arm_get_current_stackframe Nikolay Borisov
2014-05-23 16:55 ` [PATCH RESEND 0/7] Fix backtrace support in THUMB2 mode Will Deacon
2014-06-17 14:49 ` Russell King - ARM Linux
2014-06-17 15:12 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523121135.GV27560@rric.localhost \
--to=rric@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox