[PATCH for v3.15 0/2] ARM: mvebu Specificy ECC scheme for A375/385 boards

[PATCH for v3.15 0/2] ARM: mvebu Specificy ECC scheme for A375/385 boards

[Ezequiel Garcia]

Last minute fixes, which help prevent any inconsistencies between the ECC
scheme expected by the bootloader, and the one expected by the kernel.

Until now, the kernel was using the ONFI-provided "datasheet ECC requirement",
and assume the bootloader did the same thing. However, this is not the case
for these boards, where the vendor provided a bootloader with an ECC strength
that's weaker than the required.

After the introduction of the NAND ECC devicetree binding, and its support
in the pxa3xx-nand driver, we can set these values and expect them to work.

I hope it's not too late for v3.15 already.

Ezequiel Garcia (2):
  ARM: dts: Specify the NAND ECC scheme explicitly on Armada 375 DB
    board
  ARM: dts: Specify the NAND ECC scheme explicitly on Armada 385 DB
    board

 arch/arm/boot/dts/armada-375-db.dts | 2 ++
 arch/arm/boot/dts/armada-385-db.dts | 2 ++
 2 files changed, 4 insertions(+)

-- 
1.9.1

[PATCH 1/2] ARM: dts: Specify the NAND ECC scheme explicitly on Armada 375 DB board

[Ezequiel Garcia]

The factory bootloader on A375-DB boards expect the ECC strength to be
4 bits over 512 bytes. Hence, we need to specify this in the devicetree,
to prevent the kernel from assuming any different ECC scheme.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/boot/dts/armada-375-db.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/armada-375-db.dts b/arch/arm/boot/dts/armada-375-db.dts
index 772fec2..1e2919d 100644
--- a/arch/arm/boot/dts/armada-375-db.dts
+++ b/arch/arm/boot/dts/armada-375-db.dts
@@ -91,6 +91,8 @@
 				marvell,nand-keep-config;
 				marvell,nand-enable-arbiter;
 				nand-on-flash-bbt;
+				nand-ecc-strength = <4>;
+				nand-ecc-step-size = <512>;
 
 				partition at 0 {
 					label = "U-Boot";
-- 
1.9.1

[PATCH 2/2] ARM: dts: Specify the NAND ECC scheme explicitly on Armada 385 DB board

[Ezequiel Garcia]

The factory bootloader on A385-DB boards expect the ECC strength to be
4 bits over 512 bytes. Hence, we need to specify this in the devicetree,
to prevent the kernel from assuming any different ECC scheme.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/boot/dts/armada-385-db.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts
index 8b004fe..0d4327b 100644
--- a/arch/arm/boot/dts/armada-385-db.dts
+++ b/arch/arm/boot/dts/armada-385-db.dts
@@ -98,6 +98,8 @@
 				marvell,nand-keep-config;
 				marvell,nand-enable-arbiter;
 				nand-on-flash-bbt;
+				nand-ecc-strength = <4>;
+				nand-ecc-step-size = <512>;
 
 				partition at 0 {
 					label = "U-Boot";
-- 
1.9.1

[PATCH for v3.15 0/2] ARM: mvebu Specificy ECC scheme for A375/385 boards

[Jason Cooper]

On Sat, May 24, 2014 at 11:17:08AM -0300, Ezequiel Garcia wrote:
> Last minute fixes, which help prevent any inconsistencies between the ECC
> scheme expected by the bootloader, and the one expected by the kernel.
> 
> Until now, the kernel was using the ONFI-provided "datasheet ECC requirement",
> and assume the bootloader did the same thing. However, this is not the case
> for these boards, where the vendor provided a bootloader with an ECC strength
> that's weaker than the required.
> 
> After the introduction of the NAND ECC devicetree binding, and its support
> in the pxa3xx-nand driver, we can set these values and expect them to work.
> 
> I hope it's not too late for v3.15 already.
> 
> Ezequiel Garcia (2):
>   ARM: dts: Specify the NAND ECC scheme explicitly on Armada 375 DB
>     board
>   ARM: dts: Specify the NAND ECC scheme explicitly on Armada 385 DB
>     board
> 
>  arch/arm/boot/dts/armada-375-db.dts | 2 ++
>  arch/arm/boot/dts/armada-385-db.dts | 2 ++
>  2 files changed, 4 insertions(+)

As discussed on irc, I'm pushing this for v3.16 right now.  If we later
determine that it needs to be in v3.15, we can send a stable request for
these patches.

Applied to mvebu/dt for v3.16

thx,

Jason.

[PATCH for v3.15 0/2] ARM: mvebu Specificy ECC scheme for A375/385 boards

[Brian Norris]

On Sun, May 25, 2014 at 01:29:06PM -0400, Jason Cooper wrote:
> On Sat, May 24, 2014 at 11:17:08AM -0300, Ezequiel Garcia wrote:
> > Last minute fixes, which help prevent any inconsistencies between the ECC
> > scheme expected by the bootloader, and the one expected by the kernel.
> > 
> > Until now, the kernel was using the ONFI-provided "datasheet ECC requirement",
> > and assume the bootloader did the same thing. However, this is not the case
> > for these boards, where the vendor provided a bootloader with an ECC strength
> > that's weaker than the required.
> > 
> > After the introduction of the NAND ECC devicetree binding, and its support
> > in the pxa3xx-nand driver, we can set these values and expect them to work.
> > 
> > I hope it's not too late for v3.15 already.
> > 
> > Ezequiel Garcia (2):
> >   ARM: dts: Specify the NAND ECC scheme explicitly on Armada 375 DB
> >     board
> >   ARM: dts: Specify the NAND ECC scheme explicitly on Armada 385 DB
> >     board
> > 
> >  arch/arm/boot/dts/armada-375-db.dts | 2 ++
> >  arch/arm/boot/dts/armada-385-db.dts | 2 ++
> >  2 files changed, 4 insertions(+)

For the series:

Acked-by: Brian Norris <computersforpeace@gmail.com>

> As discussed on irc, I'm pushing this for v3.16 right now.  If we later
> determine that it needs to be in v3.15, we can send a stable request for
> these patches.

Not sure what went into the discussion, but for one, the binding is only
used in the pxa3xx_nand driver in the for-3.16 development branch, so it
doesn't quite seem urgent to me.

Regards,
Brian