linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: clk: imx: remove the CLK_SET_RATE_NO_REPARENT for imx_clk_mux_flags
Date: Mon, 26 May 2014 15:46:51 +0800	[thread overview]
Message-ID: <20140526074649.GA29075@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <1401095002.3400.5.camel@paszta.hi.pengutronix.de>

On Mon, May 26, 2014 at 11:03:22AM +0200, Philipp Zabel wrote:
> Am Montag, den 26.05.2014, 15:31 +0800 schrieb Huang Shijie:
> > The clocks for Quadspi controller may be different when different
> > NOR flashes are connected to the board.
> > 
> > But the CLK_SET_RATE_NO_REPARENT flag in the current imx_clk_mux_flags
> > makes the clock do not have the re-parent capability.
> > 
> > This patch removes the CLK_SET_RATE_NO_REPARENT for imx_clk_mux_flags.
> > It makes the Quadspi happy.
> > 
> > Signed-off-by: Huang Shijie <b32955@freescale.com>
> > ---
> >  arch/arm/mach-imx/clk.h |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-imx/clk.h b/arch/arm/mach-imx/clk.h
> > index e29f6eb..32d6253 100644
> > --- a/arch/arm/mach-imx/clk.h
> > +++ b/arch/arm/mach-imx/clk.h
> > @@ -108,8 +108,7 @@ static inline struct clk *imx_clk_mux_flags(const char *name,
> >  		int num_parents, unsigned long flags)
> >  {
> >  	return clk_register_mux(NULL, name, parents, num_parents,
> > -			flags | CLK_SET_RATE_NO_REPARENT, reg, shift, width, 0,
> > -			&imx_ccm_lock);
> > +			flags, reg, shift, width, 0, &imx_ccm_lock);
> >  }
> >  
> >  static inline struct clk *imx_clk_fixed_factor(const char *name,
> 
> We need CLK_SET_RATE_NO_REPARENT on the audio/video multiplexers.
> I think this change is the right thing for imx_clk_mux_flags, but at the
> same you should make sure not to drop this flag where we want to control
> a video PLL through the mux.
thanks for the quick response.

Could you tell me the clocks the audio/video used?

we can add the CLK_SET_RATE_NO_REPARENT to them.

thanks
Huang Shijie

  reply	other threads:[~2014-05-26  7:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26  7:31 [PATCH] ARM: clk: imx: remove the CLK_SET_RATE_NO_REPARENT for imx_clk_mux_flags Huang Shijie
2014-05-26  9:03 ` Philipp Zabel
2014-05-26  7:46   ` Huang Shijie [this message]
2014-05-26  9:11   ` Shawn Guo
2014-05-29  8:10 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140526074649.GA29075@shlinux1.ap.freescale.net \
    --to=b32955@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).