From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ALSA: hda: fix tegra build
Date: Mon, 26 May 2014 21:10:30 +0200 [thread overview]
Message-ID: <201405262110.31143.arnd@arndb.de> (raw)
In-Reply-To: <s5h61ksjybu.wl%tiwai@suse.de>
On Monday 26 May 2014, Takashi Iwai wrote:
> At Mon, 26 May 2014 18:14:21 +0200,
> Arnd Bergmann wrote:
> >
> > When CONFIG_PM is disabled, the CONFIG_SND_HDA_POWER_SAVE_DEFAULT symbol
> > does not get defined, which causes a build error for the hda-tegra driver:
> >
> > hda/hda_tegra.c:80:25: error: 'CONFIG_SND_HDA_POWER_SAVE_DEFAULT' undeclared here (not in a function)
> > static int power_save = CONFIG_SND_HDA_POWER_SAVE_DEFAULT;
> > ^
> > /git/arm-soc/sound/pci/hda/hda_tegra.c:235:13: warning: 'hda_tegra_disable_clocks' defined but not used [-Wunused-function]
> > static void hda_tegra_disable_clocks(struct hda_tegra *data)
> > ^
> >
> > This works around the problem by not referencing that macro
> > when CONFIG_PM is disabled. Instead, we assume that it's disabled
> > unconditionally and cannot be enabled at runtime.
> >
> > Signed-off-by: Dylan Reid <dgreid@chromium.org>
> > Reviewed-by: Stephen Warren <swarren@nvidia.com>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> Oh, you cloned me?
>
Damn, copy-paste error on my side. All three are wrong and should be Cc:,
also my Signed-off-by is missing.
Let me resend.
Arnd
prev parent reply other threads:[~2014-05-26 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 16:14 [PATCH] ALSA: hda: fix tegra build Arnd Bergmann
2014-05-26 16:31 ` Takashi Iwai
2014-05-26 19:10 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201405262110.31143.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox