From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
Date: Tue, 27 May 2014 13:14:54 +0100 [thread overview]
Message-ID: <20140527121454.GA26391@lee--X1> (raw)
In-Reply-To: <1401192188-10936-1-git-send-email-sachin.kamat@linaro.org>
On Tue, 27 May 2014, Sachin Kamat wrote:
> 'ux500_soc_attr' is local to this file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-ux500/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
> index db16b5a04ad5..4dfa04a96f4d 100644
> --- a/arch/arm/mach-ux500/cpu.c
> +++ b/arch/arm/mach-ux500/cpu.c
> @@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
> soc_dev_attr->revision = ux500_get_revision();
> }
>
> -struct device_attribute ux500_soc_attr =
> +static struct device_attribute ux500_soc_attr =
Should probably be const too.
> __ATTR(process, S_IRUGO, ux500_get_process, NULL);
>
> struct device * __init ux500_soc_device_init(const char *soc_id)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-27 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 12:03 [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr Sachin Kamat
2014-05-27 12:14 ` Lee Jones [this message]
2014-05-27 12:15 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2014-05-28 3:40 Sachin Kamat
2014-05-28 8:36 ` Lee Jones
2014-05-28 8:45 ` Sachin Kamat
2014-05-28 9:02 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527121454.GA26391@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox