* [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
@ 2014-05-28 3:40 Sachin Kamat
2014-05-28 8:36 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Sachin Kamat @ 2014-05-28 3:40 UTC (permalink / raw)
To: linux-arm-kernel
'ux500_soc_attr' is local to this file. While at it also make it
const to match the argument list of device_create_file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/mach-ux500/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
index db16b5a04ad5..dbb2970ee7da 100644
--- a/arch/arm/mach-ux500/cpu.c
+++ b/arch/arm/mach-ux500/cpu.c
@@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
soc_dev_attr->revision = ux500_get_revision();
}
-struct device_attribute ux500_soc_attr =
+static const struct device_attribute ux500_soc_attr =
__ATTR(process, S_IRUGO, ux500_get_process, NULL);
struct device * __init ux500_soc_device_init(const char *soc_id)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
2014-05-28 3:40 [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr Sachin Kamat
@ 2014-05-28 8:36 ` Lee Jones
2014-05-28 8:45 ` Sachin Kamat
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2014-05-28 8:36 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 28 May 2014, Sachin Kamat wrote:
> 'ux500_soc_attr' is local to this file. While at it also make it
> const to match the argument list of device_create_file.
What's going on Sachin? I Acked v2 of this patch an hour ago, yet
you've resent it as a v1 and without the Ack?
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-ux500/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
> index db16b5a04ad5..dbb2970ee7da 100644
> --- a/arch/arm/mach-ux500/cpu.c
> +++ b/arch/arm/mach-ux500/cpu.c
> @@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
> soc_dev_attr->revision = ux500_get_revision();
> }
>
> -struct device_attribute ux500_soc_attr =
> +static const struct device_attribute ux500_soc_attr =
> __ATTR(process, S_IRUGO, ux500_get_process, NULL);
>
> struct device * __init ux500_soc_device_init(const char *soc_id)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
2014-05-28 8:36 ` Lee Jones
@ 2014-05-28 8:45 ` Sachin Kamat
2014-05-28 9:02 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Sachin Kamat @ 2014-05-28 8:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Lee,
On 28 May 2014 14:06, Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 28 May 2014, Sachin Kamat wrote:
>
>> 'ux500_soc_attr' is local to this file. While at it also make it
>> const to match the argument list of device_create_file.
>
> What's going on Sachin? I Acked v2 of this patch an hour ago, yet
> you've resent it as a v1 and without the Ack?
Actually I posted v2 twice almost immediately. The first time I forgot to
CC LKML as requested by you. Sorry for the confusion.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
2014-05-28 8:45 ` Sachin Kamat
@ 2014-05-28 9:02 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2014-05-28 9:02 UTC (permalink / raw)
To: linux-arm-kernel
> On 28 May 2014 14:06, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 28 May 2014, Sachin Kamat wrote:
> >
> >> 'ux500_soc_attr' is local to this file. While at it also make it
> >> const to match the argument list of device_create_file.
> >
> > What's going on Sachin? I Acked v2 of this patch an hour ago, yet
> > you've resent it as a v1 and without the Ack?
>
> Actually I posted v2 twice almost immediately. The first time I forgot to
> CC LKML as requested by you. Sorry for the confusion.
Okay, I see. Thanks for clarifying.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
@ 2014-05-27 12:03 Sachin Kamat
2014-05-27 12:14 ` Lee Jones
2014-05-27 12:15 ` Lee Jones
0 siblings, 2 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-05-27 12:03 UTC (permalink / raw)
To: linux-arm-kernel
'ux500_soc_attr' is local to this file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/mach-ux500/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
index db16b5a04ad5..4dfa04a96f4d 100644
--- a/arch/arm/mach-ux500/cpu.c
+++ b/arch/arm/mach-ux500/cpu.c
@@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
soc_dev_attr->revision = ux500_get_revision();
}
-struct device_attribute ux500_soc_attr =
+static struct device_attribute ux500_soc_attr =
__ATTR(process, S_IRUGO, ux500_get_process, NULL);
struct device * __init ux500_soc_device_init(const char *soc_id)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
2014-05-27 12:03 Sachin Kamat
@ 2014-05-27 12:14 ` Lee Jones
2014-05-27 12:15 ` Lee Jones
1 sibling, 0 replies; 7+ messages in thread
From: Lee Jones @ 2014-05-27 12:14 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 27 May 2014, Sachin Kamat wrote:
> 'ux500_soc_attr' is local to this file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-ux500/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
> index db16b5a04ad5..4dfa04a96f4d 100644
> --- a/arch/arm/mach-ux500/cpu.c
> +++ b/arch/arm/mach-ux500/cpu.c
> @@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
> soc_dev_attr->revision = ux500_get_revision();
> }
>
> -struct device_attribute ux500_soc_attr =
> +static struct device_attribute ux500_soc_attr =
Should probably be const too.
> __ATTR(process, S_IRUGO, ux500_get_process, NULL);
>
> struct device * __init ux500_soc_device_init(const char *soc_id)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
2014-05-27 12:03 Sachin Kamat
2014-05-27 12:14 ` Lee Jones
@ 2014-05-27 12:15 ` Lee Jones
1 sibling, 0 replies; 7+ messages in thread
From: Lee Jones @ 2014-05-27 12:15 UTC (permalink / raw)
To: linux-arm-kernel
Don't forget to CC LKML.
> 'ux500_soc_attr' is local to this file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/mach-ux500/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
> index db16b5a04ad5..4dfa04a96f4d 100644
> --- a/arch/arm/mach-ux500/cpu.c
> +++ b/arch/arm/mach-ux500/cpu.c
> @@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
> soc_dev_attr->revision = ux500_get_revision();
> }
>
> -struct device_attribute ux500_soc_attr =
> +static struct device_attribute ux500_soc_attr =
> __ATTR(process, S_IRUGO, ux500_get_process, NULL);
>
> struct device * __init ux500_soc_device_init(const char *soc_id)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-05-28 9:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28 3:40 [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr Sachin Kamat
2014-05-28 8:36 ` Lee Jones
2014-05-28 8:45 ` Sachin Kamat
2014-05-28 9:02 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2014-05-27 12:03 Sachin Kamat
2014-05-27 12:14 ` Lee Jones
2014-05-27 12:15 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).