From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] scsi/NCR5380: dprintk macro
Date: Wed, 28 May 2014 08:53:36 -0700 [thread overview]
Message-ID: <20140528155336.GB14981@infradead.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1405290020570.3539@nippy.intranet>
On Thu, May 29, 2014 at 12:43:43AM +1000, Finn Thain wrote:
>
> This is the delta between the two submissions:
> [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure
> and
> [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure
>
> The macro definition changes were discussed on the mailing list during
> review. The idea is to get the compiler to check the parameters of
> disabled printk() calls so that the debugging code doesn't rot again.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Thanks a lot Finn!
> I know the whitespace is wrong throughout these drivers but when I put
> this patch series together it seemed best to defer the whitespace cleanup.
>(I still intend to do that cleanup.)
Yes, I ignored the whitespace warnings in the debug macro cleanups. I
fixed them up for the "newly" added code in the sun3 driver merge.
prev parent reply other threads:[~2014-05-28 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 14:43 [PATCH] scsi/NCR5380: dprintk macro Finn Thain
2014-05-28 15:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528155336.GB14981@infradead.org \
--to=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).