From: jhovold@gmail.com (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: fix rtc irq mask for sam9x5 SoCs
Date: Fri, 30 May 2014 14:09:36 +0200 [thread overview]
Message-ID: <20140530120936.GB2044@localhost> (raw)
In-Reply-To: <20140529160948.a63fa268a37d985189837a85@linux-foundation.org>
On Thu, May 29, 2014 at 04:09:48PM -0700, Andrew Morton wrote:
> On Fri, 9 May 2014 18:36:52 +0200 Johan Hovold <johan@hovold.com> wrote:
>
> > On Thu, May 08, 2014 at 07:28:04PM +0200, Boris BREZILLON wrote:
> >
> > > > You should also keep the flush (read of IMR) regardless (to make sure
> > > > the write has reached the peripheral), and remember to remove the now
> > > > unused mask variable.
> > >
> > > Does it has something to do with memory barriers ?
> > > If so, why not using writel instead of writel_relaxed ?
> >
> > You only need to use the non-relaxed version when synchronising with DMA
> > operations.
> >
> > The read-back of a register on the same device is a common technique to
> > make sure that preceding write has actually reached the peripheral
> > (write posting or flushing). In this case, it is used to make
> > (reasonably) sure that interrupts have actually been masked before
> > returning. (In the general case, you'd even need to verify the read-back
> > value to be certain that the device has changed its state.)
>
> So I grabbed this patch as it's tied to "rtc: rtc-at91rm9200: fix
> uninterruptible wait for ACKUPD" and is not in linux-next. Someone
> shout at me if that was a mistake.
The patch is needed, but it seems you got the wrong version. There was
an updated v4 posted the next day in this thread:
http://marc.info/?l=linux-kernel&m=139964712229420&w=2
Johan
next prev parent reply other threads:[~2014-05-30 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 10:28 [PATCH v2] rtc: rtc-at91rm9200: fix uninterruptible wait for ACKUPD Boris BREZILLON
2014-05-07 14:51 ` Bryan Evenson
2014-05-07 16:20 ` [PATCH] ARM: at91: fix rtc irq mask for sam9x5 SoCs Boris BREZILLON
2014-05-07 18:44 ` Bryan Evenson
2014-05-08 3:10 ` Mark Roszko
2014-05-08 17:19 ` Boris BREZILLON
2014-05-08 15:49 ` Johan Hovold
2014-05-08 17:28 ` Boris BREZILLON
2014-05-09 16:36 ` Johan Hovold
2014-05-29 23:09 ` Andrew Morton
2014-05-30 12:09 ` Johan Hovold [this message]
2014-05-08 15:54 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530120936.GB2044@localhost \
--to=jhovold@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).