linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/7] Fix backtrace support in THUMB2 mode
Date: Fri, 30 May 2014 18:19:00 +0100	[thread overview]
Message-ID: <20140530171859.GD22895@arm.com> (raw)
In-Reply-To: <1401469191-29232-1-git-send-email-nikolay.borisov@arm.com>

On Fri, May 30, 2014 at 05:59:44PM +0100, Nikolay Borisov wrote:
> From: Nikolay Borisov <Nikolay.Borisov@arm.com>
> 
> Currently all the code which deals with backtrace support assumes that R11
> is the frame-pointer. While this is the case for ARM mode and is explicitly
> documented in the AAPCS, this is not the case for THUMB2 mode.
> 
> There is no official document requiring that R11 has to be the frame pointer
> and GCC uses R7 as FP and given that R7's usage is so intertwined within GCC's
> mechanics it is unlikely to change, so fixing backtrace in THUMB2 mode seems
> in order.
> 
> This patch series rectifies the problem by first fixing the
> thread_save_fp macro to reference the correct register. Furthermore, there
> a lot of repetetive sequences of code such as :
> 
> stackframe.fp = pt_regs->ARM_fp
> stackframe.lr = pt_regs->ARM_lr
> 
> so introducing a function arm_get_current_stack_frame which both
> hides this repetition and also utilizes teh frame_pointer(regs) macro
> to reference the correct register depending on the mode.
> 
> Finally, change all the call sites so that they utilize the new routine.
> 
> Changes since v1:
>  * Nothing major, just made arg_get_current_stack frame an inline routine.

I already acked most of these, please can you add my tag?

  http://www.spinics.net/lists/arm-kernel/msg334457.html

Will

  parent reply	other threads:[~2014-05-30 17:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 16:59 [PATCH v2 0/7] Fix backtrace support in THUMB2 mode Nikolay Borisov
2014-05-30 16:59 ` [PATCH v2 1/7] ARM: Make thread_save_fp macro aware of " Nikolay Borisov
2014-05-30 16:59 ` [PATCH v2 2/7] ARM: Introduce arm_get_current_stack_frame() Nikolay Borisov
2014-05-30 17:20   ` Will Deacon
2014-06-02  8:05   ` Robert Richter
2014-05-30 16:59 ` [PATCH v3 3/7] ARM: perf: Make perf use arm_get_current_stackframe Nikolay Borisov
2014-05-30 16:59 ` [PATCH v2 4/7] ARM: time: Make use of arm_get_current_stackframe Nikolay Borisov
2014-05-30 16:59 ` [PATCH v2 5/7] ARM: unwind: Use arm_get_current_stackframe Nikolay Borisov
2014-05-30 16:59 ` [PATCH v2 6/7] ARM: traps: Make use of the frame_pointer macro Nikolay Borisov
2014-05-30 16:59 ` [PATCH v2 7/7] ARM: oprofile: Use of arm_get_current_stackframe Nikolay Borisov
2014-05-30 17:19 ` Will Deacon [this message]
2014-05-31 18:31 ` [PATCH v2 0/7] Fix backtrace support in THUMB2 mode Arnd Bergmann
2014-06-02  8:34   ` Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140530171859.GD22895@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).