linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] mmc: sdhci-esdhc-imx: add f_max field to private data
Date: Mon, 2 Jun 2014 08:40:38 +0200	[thread overview]
Message-ID: <20140602064038.GP15686@pengutronix.de> (raw)
In-Reply-To: <20140601074540.GC11061@dragon>

On Sun, Jun 01, 2014 at 03:45:43PM +0800, Shawn Guo wrote:
> > @@ -594,7 +592,7 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host,
> >  {
> >  	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> >  	struct pltfm_imx_data *imx_data = pltfm_host->priv;
> > -	unsigned int host_clock = pltfm_host->clock;
> > +	unsigned int host_clock = clk_get_rate(imx_data->clk_per);
> 
> Will this bring the issue that commit a974862faee1 (mmc: sdhci-esdhc-imx:
> fix access hardirq-unsafe lock in atomic context) fixed back to us?

Probably, yes, because the ?%$&"$$ sdhc driver still uses spinlocks.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2014-06-02  6:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 12:32 [PATCH] MMC: use mmc_of_parse in sdhci-esdhc-imx Sascha Hauer
2014-05-23 12:33 ` [PATCH 1/5] mmc: sdhci-esdhc-imx: add f_max field to private data Sascha Hauer
2014-06-01  7:45   ` Shawn Guo
2014-06-02  6:40     ` Sascha Hauer [this message]
2014-05-23 12:33 ` [PATCH 2/5] mmc: sdhci-esdhc-imx: introduce function for parsing platform_data Sascha Hauer
2014-05-23 12:33 ` [PATCH 3/5] mmc: sdhci-esdhc-imx: straighten SDHCI_QUIRK_BROKEN_CARD_DETECTION flag Sascha Hauer
2014-05-23 12:33 ` [PATCH 4/5] mmc: sdhci-esdhc-imx: use mmc_of_parse Sascha Hauer
2014-05-23 12:33 ` [PATCH 5/5] ARM: dts: imx51-babbage: Fix esdhc setup Sascha Hauer
2014-06-01 15:22   ` Shawn Guo
2014-06-05 10:39     ` Sascha Hauer
2014-06-09  3:38       ` Shawn Guo
2014-06-09  3:41   ` Shawn Guo
2014-06-10  8:01     ` Lothar Waßmann
2014-06-21  7:56   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602064038.GP15686@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).