From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c: nuc900: remove driver
Date: Mon, 2 Jun 2014 18:05:21 +0200 [thread overview]
Message-ID: <20140602160521.GF2654@katana> (raw)
In-Reply-To: <1401654925-20791-1-git-send-email-wsa@the-dreams.de>
On Sun, Jun 01, 2014 at 10:35:25PM +0200, Wolfram Sang wrote:
> Arnd said in another patch:
>
> "As far as I can tell, this driver must have produced this
> error for as long as it has been merged into the mainline kernel, but
> it was never part of the normal build tests:
>
> drivers/i2c/busses/i2c-nuc900.c: In function 'nuc900_i2c_probe':
> drivers/i2c/busses/i2c-nuc900.c:601:17: error: request for member
> 'apbfreq' in something not a structure or union
> ret = (i2c->clk.apbfreq)/(pdata->bus_freq * 5) - 1;
> ^
> This is an attempt to get the driver to build and possibly
> work correctly, although I do wonder whether we should just
> remove it, as it has clearly never worked."
>
> I agree with removing it since nobody showed interest in Arnd's fixup
> patch.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Cc: Wan ZongShun <mcuos.com@gmail.org>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140602/815b759b/attachment.sig>
prev parent reply other threads:[~2014-06-02 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 20:35 [PATCH v2] i2c: nuc900: remove driver Wolfram Sang
2014-06-02 9:07 ` Arnd Bergmann
2014-06-02 16:05 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602160521.GF2654@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox