linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] staging: allow omap4iss to be modular
Date: Thu, 12 Jun 2014 08:15:35 -0700	[thread overview]
Message-ID: <20140612151534.GF17845@atomide.com> (raw)
In-Reply-To: <2207210.T6NoNSQSCo@avalon>

* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [140612 07:52]:
> On Wednesday 11 June 2014 07:47:54 Tony Lindgren wrote:
> > 
> > These should just use either pinctrl-single.c instead for muxing.
> > Or if they are not mux registers, we do have the syscon mapping
> > available in omap4.dtsi that pbias-regulator.c is already using.
> > 
> > Laurent, got any better ideas?
> 
> The ISS driver needs to write a single register, which contains several 
> independent fields. They thus need to be controlled by a single driver. Some 
> of them might be considered to be related to pinmuxing (although I disagree on 
> that), others are certainly not about muxing (there are clock gate bits for 
> instance).
> 
> Using the syscon mapping seems like the best option. I'll give it a try.

OK if it's not strictly pinctrl related then let's not use
pinctrl-single,bits for it. You may be able to implement one or more
framework drivers for it for pinctrl/regulator/clock/transceiver
whatever that register is doing.

In any case it's best to have that handling in a separate helper driver
somewhere as it's a separate piece of hardware from the camera module.
If it does not fit into any existing frameworks then it's best to have
it in a separate driver with the camera driver.

Regards,

Tony

  reply	other threads:[~2014-06-12 15:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 14:35 [PATCH] [media] staging: allow omap4iss to be modular Arnd Bergmann
2014-06-11 14:42 ` Nishanth Menon
2014-06-11 14:49   ` Arnd Bergmann
2014-06-11 14:53     ` Nishanth Menon
2014-06-11 15:02     ` Tony Lindgren
2014-06-12 14:12     ` Laurent Pinchart
2014-06-12 14:15       ` Arnd Bergmann
2014-06-12 14:25         ` Greg KH
2014-06-12 14:28           ` Arnd Bergmann
2014-06-12 15:00             ` Laurent Pinchart
2014-06-12 15:59             ` Greg KH
2014-06-11 14:47 ` Tony Lindgren
2014-06-12 14:52   ` Laurent Pinchart
2014-06-12 15:15     ` Tony Lindgren [this message]
2014-06-12 15:31       ` Laurent Pinchart
2014-06-13  5:30         ` Tony Lindgren
2014-06-13  6:47           ` Laurent Pinchart
2014-06-13  7:53             ` Tony Lindgren
2014-06-13 10:29               ` Laurent Pinchart
2014-06-13 11:10                 ` Tony Lindgren
2014-06-13 13:17                   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140612151534.GF17845@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).