linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/2] drm/panel: consolidate unnecessary explicit dependencies
@ 2014-06-13 13:06 Russell King
  2014-06-13 13:07 ` Arnd Bergmann
  2014-06-13 13:17 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Russell King @ 2014-06-13 13:06 UTC (permalink / raw)
  To: linux-arm-kernel

DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
DRM_PANEL && DRM, whereas DRM_PANEL_SIMPLE relies upon the dependency
on the menu.

We do not need to use explicit dependencies if we make the menu depend
on DRM_PANEL && DRM - this will implicitly make each entry in the menu
depend on DRM_PANEL && DRM without this needing to be explicitly stated
against every entry.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/gpu/drm/panel/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 4ec874da5668..d83958d39f43 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -5,7 +5,7 @@ config DRM_PANEL
 	  Panel registration and lookup framework.
 
 menu "Display Panels"
-	depends on DRM_PANEL
+	depends on DRM && DRM_PANEL
 
 config DRM_PANEL_SIMPLE
 	tristate "support for simple panels"
@@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE
 
 config DRM_PANEL_LD9040
 	tristate "LD9040 RGB/SPI panel"
-	depends on DRM && DRM_PANEL
 	depends on OF
 	select SPI
 	select VIDEOMODE_HELPERS
 
 config DRM_PANEL_S6E8AA0
 	tristate "S6E8AA0 DSI video mode panel"
-	depends on DRM && DRM_PANEL
 	depends on OF
 	select DRM_MIPI_DSI
 	select VIDEOMODE_HELPERS
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v3 1/2] drm/panel: consolidate unnecessary explicit dependencies
  2014-06-13 13:06 [PATCH v3 1/2] drm/panel: consolidate unnecessary explicit dependencies Russell King
@ 2014-06-13 13:07 ` Arnd Bergmann
  2014-06-13 13:17 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-06-13 13:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 13 June 2014 14:06:11 Russell King wrote:
> DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
> DRM_PANEL && DRM, whereas DRM_PANEL_SIMPLE relies upon the dependency
> on the menu.
> 
> We do not need to use explicit dependencies if we make the menu depend
> on DRM_PANEL && DRM - this will implicitly make each entry in the menu
> depend on DRM_PANEL && DRM without this needing to be explicitly stated
> against every entry.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3 1/2] drm/panel: consolidate unnecessary explicit dependencies
  2014-06-13 13:06 [PATCH v3 1/2] drm/panel: consolidate unnecessary explicit dependencies Russell King
  2014-06-13 13:07 ` Arnd Bergmann
@ 2014-06-13 13:17 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2014-06-13 13:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Jun 13, 2014 at 02:06:11PM +0100, Russell King wrote:
> DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
> DRM_PANEL && DRM, whereas DRM_PANEL_SIMPLE relies upon the dependency
> on the menu.
> 
> We do not need to use explicit dependencies if we make the menu depend
> on DRM_PANEL && DRM - this will implicitly make each entry in the menu
> depend on DRM_PANEL && DRM without this needing to be explicitly stated
> against every entry.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
>  drivers/gpu/drm/panel/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140613/c9420170/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-13 13:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-13 13:06 [PATCH v3 1/2] drm/panel: consolidate unnecessary explicit dependencies Russell King
2014-06-13 13:07 ` Arnd Bergmann
2014-06-13 13:17 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).