linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Guangyu.Chen@freescale.com (Nicolin Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: imx6: remove wrong spdif rxtx2 clock
Date: Mon, 16 Jun 2014 10:27:15 +0800	[thread overview]
Message-ID: <20140616022713.GA21550@MrMyself> (raw)
In-Reply-To: <1402875585-29025-1-git-send-email-anssi.hannula@iki.fi>

On Mon, Jun 16, 2014 at 02:39:44AM +0300, Anssi Hannula wrote:
> The rxtx2 clock of i.MX6 S/PDIF is currently set to "asrc" clock.
> However, according to SoC documentation, rxtx2 is connected to
> ASRC_EXT_CLK, a different external clock.
> 
> Testing on Cubox-i system seems to confirm that: when fsl_spdif is
> forced to select rxtx2 as input clock, audio playback fails with an I/O
> error.
> 
> Set rxtx2 to the dummy clock by default to prevent fsl_spdif from
> selecting it.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
> Cc: Nicolin Chen <Guangyu.Chen@freescale.com>
> Cc: Mark Brown <broonie@kernel.org>

Acked, thank you!

P.S. We might also revive rxtx5 (SYSCLK) since the driver now has the
capability to derive clock from it.

> ---
> 
> This one seems clear enough.
> 
>  arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index ce0599134a69..3aef9a2f5fda 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -181,7 +181,7 @@
>  					       <&sdma 15 18 0>;
>  					dma-names = "rx", "tx";
>  					clocks = <&clks 197>, <&clks 3>,
> -						 <&clks 197>, <&clks 107>,
> +						 <&clks 197>, <&clks 0>,
>  						 <&clks 0>,   <&clks 118>,
>  						 <&clks 0>,  <&clks 139>,
>  						 <&clks 0>;
> -- 
> 1.8.4.5
> 

  parent reply	other threads:[~2014-06-16  2:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-15 23:39 [PATCH 1/2] ARM: dts: imx6: remove wrong spdif rxtx2 clock Anssi Hannula
2014-06-15 23:39 ` [PATCH 2/2] ARM: dts: imx6: remove non-working spdif rxtx4 and rxtx6 clocks Anssi Hannula
2014-06-16  2:31   ` Nicolin Chen
2014-06-16  2:27 ` Nicolin Chen [this message]
2014-06-20  7:58 ` [PATCH 1/2] ARM: dts: imx6: remove wrong spdif rxtx2 clock Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140616022713.GA21550@MrMyself \
    --to=guangyu.chen@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).