From mboxrd@z Thu Jan  1 00:00:00 1970
From: Guangyu.Chen@freescale.com (Nicolin Chen)
Date: Mon, 16 Jun 2014 10:31:53 +0800
Subject: [PATCH 2/2] ARM: dts: imx6: remove non-working spdif rxtx4 and
 rxtx6 clocks
In-Reply-To: <1402875585-29025-2-git-send-email-anssi.hannula@iki.fi>
References: <1402875585-29025-1-git-send-email-anssi.hannula@iki.fi>
 <1402875585-29025-2-git-send-email-anssi.hannula@iki.fi>
Message-ID: <20140616023152.GB21550@MrMyself>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Jun 16, 2014 at 02:39:45AM +0300, Anssi Hannula wrote:
> The S/PDIF rxtx4 and rxtx6 clock inputs are "ESAI_HCKT" and "MLB clock",
> respectively, according to the SoC documentation, and they are currently
> mapped to clocks "esai" and "mlb".
> 
> However, they do not seem to actually work correctly. Testing on a
> Cubox-i system with fsl_spdif driver forced to select one of those as
> input will result in I/O errors on audio playback, which I believe means
> missing clock signal.
> 
> Possibly the "ESAI_HCKT" and "MLB clock" refer to some other clocks
> related to ESAI and MLB, or we are missing something else.

Yes, they are actually the clocks from outside of SoC: HCKT of ESAI could
be set as an input PAD while MLB clock is the bit clock used by MLB.

> Since audio playback will not work if fsl_spdif selects these clocks
> (which happens rarely), set the inputs do dummy clocks, at least for
> now.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
> Cc: Nicolin Chen <Guangyu.Chen@freescale.com>

Acked, thank you.
Nicolin

> Cc: Mark Brown <broonie@kernel.org>
> ---
> 
> Does anyone know what is wrong here? i.e. are the clocks actually wrong
> or are we maybe doing something wrong with their setup?
> 
> Also, is this the correct way to "fix" the issue, or should we rather
> modify the driver to not select rxtx4/rxtx6 for now (assuming no one knows
> how to fix this properly, of course)?
> (I haven't been involved with device trees before)
> 
> 
>  arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 3aef9a2f5fda..f0d1c2334952 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -182,8 +182,8 @@
>  					dma-names = "rx", "tx";
>  					clocks = <&clks 197>, <&clks 3>,
>  						 <&clks 197>, <&clks 0>,
> -						 <&clks 0>,   <&clks 118>,
> -						 <&clks 0>,  <&clks 139>,
> +						 <&clks 0>,   <&clks 0>,
> +						 <&clks 0>,  <&clks 0>,
>  						 <&clks 0>;
>  					clock-names = "core",  "rxtx0",
>  						      "rxtx1", "rxtx2",
> -- 
> 1.8.4.5
>