linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/crypto: fix and improve GHASH secure hash implementation
Date: Mon, 16 Jun 2014 10:31:19 +0100	[thread overview]
Message-ID: <20140616093119.GB3971@arm.com> (raw)
In-Reply-To: <1402584187-17114-1-git-send-email-ard.biesheuvel@linaro.org>

On Thu, Jun 12, 2014 at 03:43:07PM +0100, Ard Biesheuvel wrote:
> This fixes a bug in the arm64 GHASH implementation, and switches to a faster,
> polynomial multiplication based reduction instead of one that uses
> shifts and rotates.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> 
> This is a bug fix and a performance optimization in a single patch. As the code
> has never worked correctly and was merged just a couple of days ago, I am
> assuming this is OK but if anyone would prefer the bug fix separately, I'm happy
> to split them as well.

I can push a performance optimisation patch as well but I would prefer
to separate the bug-fixing part. Could you please also describe what the
bug was for future reference?

Thanks.

-- 
Catalin

      parent reply	other threads:[~2014-06-16  9:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 14:43 [PATCH] arm64/crypto: fix and improve GHASH secure hash implementation Ard Biesheuvel
2014-06-12 14:48 ` Catalin Marinas
2014-06-12 14:54   ` Ard Biesheuvel
2014-06-16  9:31 ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140616093119.GB3971@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).