[PATCH] ARM: shmobile: rcar-gen2: correct return value of shmobile_smp_apmu_suspend_init

Simon Horman
2014-06-16T12:25:48Z

On Mon, Jun 16, 2014 at 04:13:38PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 06/16/2014 03:27 PM, Simon Horman wrote:
>
> >The dummy shmobile_smp_apmu_suspend_init() function provided when
> >CPU_IDLE is not set should not return a value as per the signature
> >of the function.
>
> >This problem appears to have been introduced by
> >867ba81f728f1daa ("ARM: shmobile: APMU: Add Core-Standby-state for Suspend
> >to RAM").
>
> >Cc: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> [...]
>
> >diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
> >index 8f0cd57..46766fc 100644
> >--- a/arch/arm/mach-shmobile/include/mach/common.h
> >+++ b/arch/arm/mach-shmobile/include/mach/common.h
> >@@ -38,7 +38,7 @@ int shmobile_suspend_init(void);
> > void shmobile_smp_apmu_suspend_init(void);
> > #else
> > static inline int shmobile_suspend_init(void) { return 0; }
> >-static inline void shmobile_smp_apmu_suspend_init(void) { return 0; }
> >+static inline void shmobile_smp_apmu_suspend_init(void) { return; }
>
> I wonder why you kept *return* at all?

Thanks, I will remove it.