From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: select ARM_CPU_SUSPEND for Marvell EBU v7 platforms
Date: Tue, 17 Jun 2014 21:22:11 -0300 [thread overview]
Message-ID: <20140618002211.GA4094@arch.cereza> (raw)
In-Reply-To: <1402488397-31381-1-git-send-email-thomas.petazzoni@free-electrons.com>
On 11 Jun 02:06 PM, Thomas Petazzoni wrote:
> On Marvell Armada platforms, the PMSU (Power Management Service Unit)
> controls a number of power management related activities, needed for
> things like suspend/resume, CPU hotplug, cpuidle or even simply SMP.
>
> Since cpuidle support was added for Armada XP, the pmsu.c file in
> arch/arm/mach-mvebu/ calls the cpu_suspend() and cpu_resume() ARM
> functions, which are only available when
> CONFIG_ARM_CPU_SUSPEND=y. Therefore, configurations that have
> CONFIG_ARM_CPU_SUSPEND disabled due to PM_SLEEP being disabled no
> longer build properly, due to undefined references to cpu_suspend()
> and cpu_resume().
>
> To fix this, this patch simply ensures CONFIG_ARM_CPU_SUSPEND is
> always enabled for Marvell EBU v7 platforms. Doing things in a more
> fine-grained way would require a lot of #ifdef-ery in pmsu.c to
> isolate the parts that use cpu_suspend()/cpu_resume(), and those parts
> would anyway have been needed as soon as either one of suspend/resume,
> CPU hotplug or cpuidle was enabled.
>
> Reported-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Jason, this patch is against the mvebu/soc branch, and should be
> pushed to 3.16, where the problem was introduced.
>
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-18 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 12:06 [PATCH] ARM: mvebu: select ARM_CPU_SUSPEND for Marvell EBU v7 platforms Thomas Petazzoni
2014-06-18 0:22 ` Ezequiel Garcia [this message]
2014-06-20 20:39 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618002211.GA4094@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).