From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: mvebu: Use system controller to get the soc id when possible
Date: Fri, 20 Jun 2014 21:12:04 +0200 [thread overview]
Message-ID: <20140620191204.GA32533@lunn.ch> (raw)
In-Reply-To: <20140620190052.GD21711@titan.lakedaemon.net>
> > +int mvebu_system_controller_get_soc_id(u32 *dev, u32 *rev)
> > +{
> > + if (of_machine_is_compatible("marvell,armada38x") &&
>
> As Sergei commented on your documentation patch, we try to avoid
> wildcards in compatible strings. Perhaps a match list would be more
> appropriate?
I'm being pedantic, but in this invocation, it is not a wildcard. It will
match one and only one compatible string.
However, we have the issue that 38x is not introduced in this patch,
it has been there for a while. So would you like another patch series
removing it from the DT files? A quick grep suggests nothing is using
"marvell,armada38x" except this patch. So it should not be a backwards
compatible issue.
Andrew
next prev parent reply other threads:[~2014-06-20 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 14:35 [PATCH v2 0/2] Improve mvebu_get_soc_id Gregory CLEMENT
2014-06-20 14:35 ` [PATCH v2 1/2] ARM: mvebu: Use the a standard errno in mvebu_get_soc_id Gregory CLEMENT
2014-06-20 15:47 ` Thomas Petazzoni
2014-06-21 1:02 ` Jason Cooper
2014-06-20 14:35 ` [PATCH v2 2/2] ARM: mvebu: Use system controller to get the soc id when possible Gregory CLEMENT
2014-06-20 14:49 ` Ezequiel Garcia
2014-06-20 19:00 ` Jason Cooper
2014-06-20 19:12 ` Andrew Lunn [this message]
2014-06-20 19:38 ` Jason Cooper
2014-06-20 19:15 ` [PATCH v2 0/2] Improve mvebu_get_soc_id Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620191204.GA32533@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox