From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc.
Date: Sat, 21 Jun 2014 15:12:21 +0800 [thread overview]
Message-ID: <20140621071219.GH6818@dragon> (raw)
In-Reply-To: <1403096216-21292-1-git-send-email-denis@eukrea.com>
On Wed, Jun 18, 2014 at 02:56:56PM +0200, Denis Carikli wrote:
> The following commit:
> 89d7e5c mmc: sdhci-esdhc-imx: add runtime pm support
> has the effect of also disabling the hardware card detect
> in runtime pm.
>
> We switch to GPIO based detection to avoid this issue.
>
> This patch is based on:
> ARM: dts: imx51-babbage: Fix esdhc setup
>
> Signed-off-by: Denis Carikli <denis@eukrea.com>
> ---
> .../boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> index 75e66c9..1d77381 100644
> --- a/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> +++ b/arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts
> @@ -108,6 +108,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_esdhc1 &pinctrl_esdhc1_cd>;
> fsl,cd-controller;
The property should be dropped now.
> + cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> +
This new line is not really necessary.
I fixed them up when applying.
Shawn
> status = "okay";
> };
>
> @@ -206,7 +208,7 @@
>
> pinctrl_esdhc1_cd: esdhc1_cd {
> fsl,pins = <
> - MX51_PAD_GPIO1_0__SD1_CD 0x20d5
> + MX51_PAD_GPIO1_0__GPIO1_0 0xd5
> >;
> };
>
> --
> 1.7.9.5
>
prev parent reply other threads:[~2014-06-21 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 12:56 [PATCH] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: unbreak esdhc Denis Carikli
2014-06-21 4:59 ` Shawn Guo
2014-06-21 7:12 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140621071219.GH6818@dragon \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).