linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/6] input: misc: Add driver for AXP20x Power Enable Key
Date: Mon, 30 Jun 2014 10:47:12 +0100	[thread overview]
Message-ID: <20140630094712.GX7262@leverpostej> (raw)
In-Reply-To: <1404066237-20234-4-git-send-email-carlo@caione.org>

On Sun, Jun 29, 2014 at 07:23:54PM +0100, Carlo Caione wrote:
> This patch add support for the Power Enable Key found on MFD AXP202 and
> AXP209. Besides the basic support for the button, the driver adds two
> entries in sysfs to configure the time delay for power on/off.
> 
> Signed-off-by: Carlo Caione <carlo@caione.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/misc/Kconfig      |  11 ++
>  drivers/input/misc/Makefile     |   1 +
>  drivers/input/misc/axp20x-pek.c | 281 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 293 insertions(+)
>  create mode 100644 drivers/input/misc/axp20x-pek.c

[...]

> +static int axp20x_pek_probe(struct platform_device *pdev)
> +{
> +       struct axp20x_pek *axp20x_pek;
> +       struct axp20x_dev *axp20x;
> +       struct input_dev *idev;
> +       int error;
> +
> +       axp20x_pek = devm_kzalloc(&pdev->dev, sizeof(struct axp20x_pek),
> +                                 GFP_KERNEL);

You can use sizeof(*axp20x_pek) here.

[...]

> +static struct platform_driver axp20x_pek_driver = {
> +       .probe          = axp20x_pek_probe,
> +       .remove         = axp20x_pek_remove,
> +       .driver         = {
> +               .name           = "axp20x-pek",
> +               .owner          = THIS_MODULE,
> +       },
> +};
> +module_platform_driver(axp20x_pek_driver);

So this requires platform data rather than a DTB? Or have I missed
something?

Thanks,
Mark.

  reply	other threads:[~2014-06-30  9:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-29 18:23 [PATCH v7 0/6] mfd: AXP20x: Add support for AXP202 and AXP209 Carlo Caione
2014-06-29 18:23 ` [PATCH v7 1/6] mfd: AXP20x: Add bindings documentation Carlo Caione
2014-06-30  9:48   ` Mark Rutland
2014-12-03 10:05     ` [linux-sunxi] " Chen-Yu Tsai
2014-06-29 18:23 ` [PATCH v7 2/6] dt-bindings: add vendor-prefix for X-Powers Carlo Caione
2014-06-29 18:23 ` [PATCH v7 3/6] input: misc: Add driver for AXP20x Power Enable Key Carlo Caione
2014-06-30  9:47   ` Mark Rutland [this message]
2014-06-30 17:43     ` Carlo Caione
2014-06-29 18:23 ` [PATCH v7 4/6] input: misc: Add ABI docs for AXP20x PEK Carlo Caione
2014-06-29 18:23 ` [PATCH v7 5/6] ARM: sunxi: Add AXP20x support in defconfig Carlo Caione
2014-06-29 18:23 ` [PATCH v7 6/6] ARM: sunxi: Add AXP20x support multi_v7_defconfig Carlo Caione
2014-10-22  6:28 ` [PATCH v7 0/6] mfd: AXP20x: Add support for AXP202 and AXP209 Bruno Prémont
2014-10-22  7:59   ` Maxime Ripard
2014-10-22 10:22     ` [linux-sunxi] " Carlo Caione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140630094712.GX7262@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).