public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] ARM: imx53: mark imx53_dt_board_compat as const
@ 2014-06-30  9:37 Lucas Stach
  2014-07-01  8:07 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2014-06-30  9:37 UTC (permalink / raw)
  To: linux-arm-kernel

Otherwise GCC will mark the .init.rodata section
R/W, which causes a compile error once we add other
real R/O data, which happens with patch
"ARM: imx53: globally disable supervisor protect".

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/mach-imx/mach-imx53.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/mach-imx53.c b/arch/arm/mach-imx/mach-imx53.c
index d757d8cbebd1..c3a404ce39e6 100644
--- a/arch/arm/mach-imx/mach-imx53.c
+++ b/arch/arm/mach-imx/mach-imx53.c
@@ -45,7 +45,7 @@ static void __init imx53_dt_init(void)
 	}
 }
 
-static const char *imx53_dt_board_compat[] __initconst = {
+static const char * const imx53_dt_board_compat[] __initconst = {
 	"fsl,imx53",
 	NULL
 };
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: imx53: mark imx53_dt_board_compat as const
  2014-06-30  9:37 [PATCH] ARM: imx53: mark imx53_dt_board_compat as const Lucas Stach
@ 2014-07-01  8:07 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2014-07-01  8:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jun 30, 2014 at 11:37:48AM +0200, Lucas Stach wrote:
> Otherwise GCC will mark the .init.rodata section
> R/W, which causes a compile error once we add other
> real R/O data, which happens with patch
> "ARM: imx53: globally disable supervisor protect".
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

The same change needs to be applied on some other IMX platforms, so I
just send a new patch based on this.

Shawn

> ---
>  arch/arm/mach-imx/mach-imx53.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/mach-imx53.c b/arch/arm/mach-imx/mach-imx53.c
> index d757d8cbebd1..c3a404ce39e6 100644
> --- a/arch/arm/mach-imx/mach-imx53.c
> +++ b/arch/arm/mach-imx/mach-imx53.c
> @@ -45,7 +45,7 @@ static void __init imx53_dt_init(void)
>  	}
>  }
>  
> -static const char *imx53_dt_board_compat[] __initconst = {
> +static const char * const imx53_dt_board_compat[] __initconst = {
>  	"fsl,imx53",
>  	NULL
>  };
> -- 
> 2.0.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-01  8:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-30  9:37 [PATCH] ARM: imx53: mark imx53_dt_board_compat as const Lucas Stach
2014-07-01  8:07 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox