From: matt@console-pimps.org (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] efi: efistub: refactor stub components
Date: Tue, 1 Jul 2014 17:22:21 +0100 [thread overview]
Message-ID: <20140701162221.GG7539@console-pimps.org> (raw)
In-Reply-To: <CAKv+Gu8sHpHNEJhDrrJcN12rVrhRgprzmNeJ_BoMCbL+Gh2-NQ@mail.gmail.com>
On Tue, 01 Jul, at 05:20:21PM, Ard Biesheuvel wrote:
>
> ... but that wasn't your question ....
>
> The reason this can't live in "efistub.h" is that it gets included by
> bits under arch/xxx
> So perhaps moving the local "efistub.h" to <linux/efistub.h> would be
> appropriate, yes.
I didn't mean that we should add include/linux/efistub.h, rather that we
should try adding them to efistub.h or asm/efi.h.
But I see that isn't going to work too well and there's no easy fix.
Let's just leave things as they are for now.
Long term, I've been thinking of splitting up include/linux/efi.h. It's
currently weighing in at 1208 lines and contains pieces for all sorts of
different chunks of EFI code, 32-bit and 64-bit versions of data
structures, etc.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-07-01 16:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 14:23 [PATCH v2 0/5] efistub: convert into static library Ard Biesheuvel
2014-06-26 14:23 ` [PATCH v2 1/5] efi/arm64: avoid EFI_ERROR as a generic return code Ard Biesheuvel
2014-06-26 14:23 ` [PATCH v2 2/5] efi/x86: efistub: move shared dependencies to <asm/efi.h> Ard Biesheuvel
2014-07-02 12:59 ` Mark Salter
2014-07-02 13:02 ` Ard Biesheuvel
2014-06-26 14:23 ` [PATCH v2 3/5] efi/arm64: " Ard Biesheuvel
2014-06-26 14:23 ` [PATCH v2 4/5] efi: efistub: refactor stub components Ard Biesheuvel
2014-07-01 15:11 ` Matt Fleming
2014-07-01 15:18 ` Ard Biesheuvel
2014-07-01 15:20 ` Ard Biesheuvel
2014-07-01 16:22 ` Matt Fleming [this message]
2014-06-26 14:23 ` [PATCH v2 5/5] efi: efistub: convert into static library Ard Biesheuvel
2014-07-02 11:15 ` Matt Fleming
2014-07-02 11:23 ` Ard Biesheuvel
2014-07-02 11:49 ` Ard Biesheuvel
2014-07-01 18:39 ` [PATCH v2 0/5] " Matt Fleming
2014-07-01 18:55 ` Ard Biesheuvel
2014-07-01 19:01 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701162221.GG7539@console-pimps.org \
--to=matt@console-pimps.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).