From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: convert all "mov.* pc, reg" to "bx reg" for ARMv6+
Date: Tue, 1 Jul 2014 19:51:26 +0200 [thread overview]
Message-ID: <20140701175126.GA20086@lunn.ch> (raw)
In-Reply-To: <E1X20Rs-00082S-KI@rmk-PC.arm.linux.org.uk>
On Tue, Jul 01, 2014 at 04:58:24PM +0100, Russell King wrote:
> ARMv6 and greater introduced a new instruction ("bx") which can be used
> to return from function calls. Recent CPUs perform better when the
> "bx lr" instruction is used rather than the "mov pc, lr" instruction,
> and this sequence is strongly recommended to be used by the ARM
> architecture manual (section A.4.1.1).
>
> We provide a new macro "ret" with all its variants for the condition
> code which will resolve to the appropriate instruction.
>
> Rather than doing this piecemeal, and miss some instances, change all
> the "mov pc" instances to use the new macro, with the exception of
> the "movs" instruction and the kprobes code. This allows us to detect
> the "mov pc, lr" case and fix it up - and also gives us the possibility
> of deploying this for other registers depending on the CPU selection.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Hi Russell
Boot tested on kirkwood.
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next parent reply other threads:[~2014-07-01 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1X20Rs-00082S-KI@rmk-PC.arm.linux.org.uk>
2014-07-01 17:51 ` Andrew Lunn [this message]
2014-07-02 5:10 ` [PATCH] ARM: convert all "mov.* pc, reg" to "bx reg" for ARMv6+ Shawn Guo
2014-07-02 9:02 ` Tony Lindgren
2014-07-02 9:24 ` Gregory CLEMENT
2014-07-02 11:31 ` Sekhar Nori
2014-07-04 10:11 ` Christoffer Dall
2014-07-04 11:09 ` Haojian Zhuang
2014-07-04 11:27 ` Stefano Stabellini
2014-07-04 14:24 ` Uwe Kleine-König
2014-07-07 9:21 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701175126.GA20086@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).