[PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init

Russell King - ARM Linux
2014-06-25T13:13:33Z

On Wed, Jun 25, 2014 at 02:00:42PM +0100, Russell King - ARM Linux wrote:
> On Tue, Jun 24, 2014 at 05:04:36PM -0500, Darren Etheridge wrote:
> > On 06/17/2014 09:17 AM, Guido Mart?nez wrote:
> >> Use module_init instead of late_initcall, as is the norm for modular
> >> drivers.
> >>
> >> module_init was used until 6e8de0bd6a51fdeebd5d975c4fcc426f730b339b
> >> ("drm/tilcdc: add encoder slave (v2)") changed it to a late_initcall,
> >> but it does not explain why. Tests show it's working properly with
> >> module_init.
> >>
> >
> > If I recall, the late_initcall stuff was done to try and make sure the
> > tda998x/i2c subsystem came up before tilcdc. However it didn't always
> > work so we added commit: 39de6194131c155901f96686a063212656d80c2e to try
> > and ensure the ordering. This might be why changing back to module_init
> > is fine (and I agree with your assessment from my testing).
>
> There's a solution to that... I have patches which convert the tda998x
> driver to also register into the component helpers as well as remaining
> as a drm slave device. This makes it possible to transition tilcdc to
> use the component helper to solve the initialisation ordering.
>
> I'll (re-)post them later today.

Except Daniel Mack will not be receiving any copies of them:

zonque at gmail.com
SMTP error from remote mail server after end of data:
host gmail-smtp-in.l.google.com [2a00:1450:400c:c03::1a]:
550-5.7.1 [2001:4d48:ad52:3201:214:fdff:fe10:1be6 12] Our system has
550-5.7.1 detected that this message is likely unsolicited mail. To reduce the
550-5.7.1 amount of spam sent to Gmail, this message has been blocked. Please
550-5.7.1 visit
550-5.7.1 http://support.google.com/mail/bin/answer.py?hl=en&answer=188131 for
550 5.7.1 more information. fs8si6627678wib.99 - gsmtp

Google's anti-ham filter seems to be working perfectly, allowing spam
through and blocking real messages... as usual. And as usual, google
provides no support for this crap. Gmail has a history of increasingly
blocking legitimate email in their alleged anti-spam fight. Don't use
gmail.

--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.