* [PATCH v5 1/2] libahci: Implement the function ahci_restart_engine to restart the port dma engine.
[not found] ` <1404296108-16233-2-git-send-email-stripathi@apm.com>
@ 2014-07-03 14:03 ` Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2014-07-03 14:03 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Wed, Jul 02, 2014 at 03:45:07PM +0530, Suman Tripathi wrote:
> +int ahci_restart_engine(struct ata_port *ap)
> +{
> + struct ahci_host_priv *hpriv = ap->host->private_data;
> +
> + ahci_stop_engine(ap);
> + ahci_start_fis_rx(ap);
> + hpriv->start_engine(ap);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(ahci_restart_engine);
I don't get this function. No other ahci needs it and it's not even
contained libahci proper. It calls back to the calling low level
driver. Why not just expose ahci_start_fis_rx() and implement the
above in xgene?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-07-03 14:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1404296108-16233-1-git-send-email-stripathi@apm.com>
[not found] ` <1404296108-16233-2-git-send-email-stripathi@apm.com>
2014-07-03 14:03 ` [PATCH v5 1/2] libahci: Implement the function ahci_restart_engine to restart the port dma engine Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).