* [PATCH] ARM: imx: imx6sx uses imx6q cpuidle code
@ 2014-07-03 14:16 Arnd Bergmann
2014-07-03 14:23 ` Shawn Guo
2014-07-03 17:57 ` Uwe Kleine-König
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2014-07-03 14:16 UTC (permalink / raw)
To: linux-arm-kernel
Building a kernel for imx6sx but without imx6q support results in
this link error because of the missing cpuidle driver:
arch/arm/mach-imx/built-in.o: In function `imx6sx_init_late'::(.init.text+0xc228):
undefined reference to `imx6q_cpuidle_init'
This patch adds a Makefile entry so we always build support for
the imx6q_cpuidle code when at least one of the 6sx or 6q variants
are enabled.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
index a364e20..d0179cd 100644
--- a/arch/arm/mach-imx/Makefile
+++ b/arch/arm/mach-imx/Makefile
@@ -31,6 +31,7 @@ ifeq ($(CONFIG_CPU_IDLE),y)
obj-$(CONFIG_SOC_IMX5) += cpuidle-imx5.o
obj-$(CONFIG_SOC_IMX6Q) += cpuidle-imx6q.o
obj-$(CONFIG_SOC_IMX6SL) += cpuidle-imx6sl.o
+obj-$(CONFIG_SOC_IMX6SX) += cpuidle-imx6q.o
endif
ifdef CONFIG_SND_IMX_SOC
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: imx: imx6sx uses imx6q cpuidle code
2014-07-03 14:16 [PATCH] ARM: imx: imx6sx uses imx6q cpuidle code Arnd Bergmann
@ 2014-07-03 14:23 ` Shawn Guo
2014-07-03 17:57 ` Uwe Kleine-König
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2014-07-03 14:23 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 03, 2014 at 04:16:06PM +0200, Arnd Bergmann wrote:
> Building a kernel for imx6sx but without imx6q support results in
> this link error because of the missing cpuidle driver:
>
> arch/arm/mach-imx/built-in.o: In function `imx6sx_init_late'::(.init.text+0xc228):
> undefined reference to `imx6q_cpuidle_init'
>
> This patch adds a Makefile entry so we always build support for
> the imx6q_cpuidle code when at least one of the 6sx or 6q variants
> are enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the fixing, Arnd. Applied.
Shawn
>
> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> index a364e20..d0179cd 100644
> --- a/arch/arm/mach-imx/Makefile
> +++ b/arch/arm/mach-imx/Makefile
> @@ -31,6 +31,7 @@ ifeq ($(CONFIG_CPU_IDLE),y)
> obj-$(CONFIG_SOC_IMX5) += cpuidle-imx5.o
> obj-$(CONFIG_SOC_IMX6Q) += cpuidle-imx6q.o
> obj-$(CONFIG_SOC_IMX6SL) += cpuidle-imx6sl.o
> +obj-$(CONFIG_SOC_IMX6SX) += cpuidle-imx6q.o
> endif
>
> ifdef CONFIG_SND_IMX_SOC
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: imx: imx6sx uses imx6q cpuidle code
2014-07-03 14:16 [PATCH] ARM: imx: imx6sx uses imx6q cpuidle code Arnd Bergmann
2014-07-03 14:23 ` Shawn Guo
@ 2014-07-03 17:57 ` Uwe Kleine-König
2014-07-04 1:54 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2014-07-03 17:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello Arnd,
On Thu, Jul 03, 2014 at 04:16:06PM +0200, Arnd Bergmann wrote:
> obj-$(CONFIG_SOC_IMX5) += cpuidle-imx5.o
> obj-$(CONFIG_SOC_IMX6Q) += cpuidle-imx6q.o
> obj-$(CONFIG_SOC_IMX6SL) += cpuidle-imx6sl.o
> +obj-$(CONFIG_SOC_IMX6SX) += cpuidle-imx6q.o
as this line looks wrong it might be worth a comment ...
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: imx: imx6sx uses imx6q cpuidle code
2014-07-03 17:57 ` Uwe Kleine-König
@ 2014-07-04 1:54 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2014-07-04 1:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 03, 2014 at 07:57:02PM +0200, Uwe Kleine-K?nig wrote:
> Hello Arnd,
>
> On Thu, Jul 03, 2014 at 04:16:06PM +0200, Arnd Bergmann wrote:
> > obj-$(CONFIG_SOC_IMX5) += cpuidle-imx5.o
> > obj-$(CONFIG_SOC_IMX6Q) += cpuidle-imx6q.o
> > obj-$(CONFIG_SOC_IMX6SL) += cpuidle-imx6sl.o
> > +obj-$(CONFIG_SOC_IMX6SX) += cpuidle-imx6q.o
> as this line looks wrong it might be worth a comment ...
Okay, I fixed it up as below.
# i.MX6SX reuses i.MX6Q cpuidle driver
obj-$(CONFIG_SOC_IMX6SX) += cpuidle-imx6q.o
Shawn
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-04 1:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-03 14:16 [PATCH] ARM: imx: imx6sx uses imx6q cpuidle code Arnd Bergmann
2014-07-03 14:23 ` Shawn Guo
2014-07-03 17:57 ` Uwe Kleine-König
2014-07-04 1:54 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).