From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx
Date: Mon, 7 Jul 2014 13:29:56 +0800 [thread overview]
Message-ID: <20140707052955.GK30239@dragon> (raw)
In-Reply-To: <CAOMZO5CkFufrNTf=uG0qHxZuqf1B-=QP2UBM0R_6dk6peT+7NQ@mail.gmail.com>
On Fri, Jul 04, 2014 at 12:47:46PM -0300, Fabio Estevam wrote:
> On Fri, Jul 4, 2014 at 11:55 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
>
> >> However, I still have a question: wouldn't it be better to describe
> >> the compatible string as:
> >> compatible = "fsl,imx6sl-sdma", "fsl,imx6q-sdma", "fsl,imx35-sdma"; ?
> >
> > No, it wouldn't be better or necessary.
>
> I have some trouble understanding when/if the three elements need to
> be passed into the compatible string.
>
> For example: on mx6sl ssi node:
>
> ssi1: ssi at 02028000 {
> compatible = "fsl,imx6sl-ssi",
> "fsl,imx51-ssi",
> "fsl,imx21-ssi";
I would say either one below is correct.
- compatible = "fsl,imx6sl-ssi", "fsl,imx51-ssi", "fsl,imx21-ssi";
- compatible = "fsl,imx6sl-ssi", "fsl,imx51-ssi";
But when commit 98ea6ad2edd2 (ARM: dts: imx6: use imx51-ssi) updates the
compatible, it might be better to just replace "fsl,imx21-ssi" with
"fsl,imx51-ssi".
>
> However on mx6sx node we have:
>
> ssi1: ssi at 02028000 {
> compatible = "fsl,imx6sx-ssi", "fsl,imx21-ssi";
>
> Which one is correct? Care to explain?
This one is incorrect now. The "fsl,imx21-ssi" should be replaced by
"fsl,imx51-ssi" per commit above. Care to send a patch for it?
Shawn
prev parent reply other threads:[~2014-07-07 5:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 6:46 [PATCH] ARM: dts: imx: correct sdma compatbile for imx6sl and imx6sx Shawn Guo
2014-07-04 6:58 ` Yibin Gong
2014-07-04 13:53 ` Fabio Estevam
2014-07-04 14:55 ` Shawn Guo
2014-07-04 15:47 ` Fabio Estevam
2014-07-07 5:29 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707052955.GK30239@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).