[PATCH 1/2] ARM: efm32: switch to properly namespaced location property

[u.kleine-koenig@pengutronix.de (Uwe Kleine-König)]

Hi Olof,

On Mon, Jul 07, 2014 at 10:46:52PM -0700, Olof Johansson wrote:
> On Mon, Jun 30, 2014 at 8:41 AM, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > Now that both spi and serial driver support these (commits f2bb31057a42
> > (spi: efm32: properly namespace location property) and
> > 74be65a3cff5 (serial: efm32: properly namespace location property)) use
> > the better names.
> >
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/efm32gg-dk3750.dts | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/efm32gg-dk3750.dts b/arch/arm/boot/dts/efm32gg-dk3750.dts
> > index b4031fa4a567..d5dd2a2a7970 100644
> > --- a/arch/arm/boot/dts/efm32gg-dk3750.dts
> > +++ b/arch/arm/boot/dts/efm32gg-dk3750.dts
> > @@ -43,7 +43,7 @@
> >
> >                 spi0: spi at 4000c000 { /* USART0 */
> >                         cs-gpios = <&gpio 68 1>; // E4
> > -                       location = <1>;
> > +                       efm32,location = <1>;
> 
> Hrm, the prefix is normally the vendor, not the platform. I see that
Don't considering what it used normally (and I didn't do it wrong on
purpose) I consider a string identifying the platform to be more
sensible here. For one thing because the vendor can change (as it did with
efm32). Another reason is that the vendor can create another platform
that also needs some devices with a location property that has a
completely different semantic but would get the same name.
(Ok, if the semantic on the different platform is similar
$vendor,location would be more appropriate. Probably the decision on
what name to pick should be considered case by case.)

Just my 0.02 ?,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |