linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend] arm64: dmi: Add SMBIOS/DMI support
Date: Tue, 8 Jul 2014 10:30:24 +0100	[thread overview]
Message-ID: <20140708093024.GE8235@arm.com> (raw)
In-Reply-To: <CAKv+Gu_n7QV+_nUpeV8LH-i4eSGTHbaxU4OLwWuyaTHAGXqOjA@mail.gmail.com>

On Tue, Jul 08, 2014 at 10:27:06AM +0100, Ard Biesheuvel wrote:
> On 8 July 2014 11:15, Will Deacon <will.deacon@arm.com> wrote:
> > On Tue, Jul 08, 2014 at 09:55:53AM +0100, Ard Biesheuvel wrote:
> >> > +#include <linux/slab.h>
> >> > +#include <linux/efi.h>
> >> > +
> >> > +/* Use efi mappings for DMI */
> >> > +#define dmi_early_remap(x, l)          efi_lookup_mapped_addr(x)
> >
> > Throwing away the length doesn't feel right, especially since the efi map
> > *does* have a size field.
> >
> 
> The thing to realize here is that, instead of doing actual ioremap()
> or early_ioremap() calls, we just reuse an existing EFI mapping here.
> (On x86, DMI/SMBIOS and EFI are not as tightly coupled, whereas on
> arm64, the former implies the latter). So would you prefer some kind
> of test against the size of the mapping before doing that?

Yeah, might not be a bad idea. Even if the thing happens to work by
construction, we still have an API that takes a size, so checking it's what
we have mapped sounds sensible.

Will

  reply	other threads:[~2014-07-08  9:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 10:34 [PATCH resend] arm64: dmi: Add SMBIOS/DMI support Ard Biesheuvel
2014-07-08  8:55 ` Ard Biesheuvel
2014-07-08  9:15   ` Will Deacon
2014-07-08  9:27     ` Ard Biesheuvel
2014-07-08  9:30       ` Will Deacon [this message]
2014-07-10  5:49         ` Ard Biesheuvel
  -- strict thread matches above, loose matches on Subject: below --
2014-09-19 17:00 Ard Biesheuvel
2014-09-19 17:25 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708093024.GE8235@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).