From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller
Date: Tue, 8 Jul 2014 09:22:16 -0400 [thread overview]
Message-ID: <20140708132216.GA4979@htj.dyndns.org> (raw)
In-Reply-To: <1403101406-15439-7-git-send-email-mperttunen@nvidia.com>
(cc'ing Hans)
Hans, can you please review this patch?
On Wed, Jun 18, 2014 at 05:23:25PM +0300, Mikko Perttunen wrote:
> +#define SATA_CONFIGURATION_0 0x180
> +#define SATA_CONFIGURATION_EN_FPCI BIT(0)
Let's just indent uniformly. The new line should give enough visual
hint on grouping.
> +struct tegra_ahci_priv {
> + struct platform_device *pdev;
> + void __iomem *sata_regs;
> + struct reset_control *sata_rst;
> + struct reset_control *sata_oob_rst;
> + struct reset_control *sata_cold_rst;
> + struct clk *sata_clk;
> + struct clk *sata_oob_clk;
> + struct clk *cml1_clk;
> + struct clk *plle_clk;
> + struct regulator_bulk_data supplies[5];
> + struct phy *padctl_phy;
> +};
And please indent the declared fields uniformly too.
Except for the above nitpicks, generally looks good to me but let's
wait for Hans' review.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-08 13:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 14:23 [PATCH v2 0/7] Serial ATA support for NVIDIA Tegra124 Mikko Perttunen
2014-06-18 14:23 ` [PATCH v2 1/7] of: Add NVIDIA Tegra SATA controller binding Mikko Perttunen
2014-06-18 14:23 ` [PATCH v2 2/7] ARM: tegra: Add SATA controller to Tegra124 device tree Mikko Perttunen
2014-06-18 14:23 ` [PATCH v2 3/7] ARM: tegra: Add SATA and SATA power to Jetson TK1 " Mikko Perttunen
2014-06-18 14:23 ` [PATCH v2 4/7] clk: tegra: Enable hardware control of SATA PLL Mikko Perttunen
2014-07-08 1:26 ` Andrew Bresticker
2014-07-08 7:30 ` [PATCH] clk: tegra: Use XUSB-compatible SATA PLL sequence Mikko Perttunen
2014-07-08 8:16 ` Peter De Schrijver
2014-06-18 14:23 ` [PATCH v2 5/7] clk: tegra: Add SATA clocks to Tegra124 initialization table Mikko Perttunen
2014-06-24 19:32 ` Stephen Warren
2014-06-18 14:23 ` [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller Mikko Perttunen
2014-06-24 19:35 ` Stephen Warren
2014-06-26 11:18 ` Mikko Perttunen
2014-07-08 8:20 ` Mikko Perttunen
2014-07-08 13:22 ` Tejun Heo [this message]
2014-07-08 13:38 ` Mikko Perttunen
2014-07-14 6:21 ` Mikko Perttunen
2014-07-14 6:25 ` Hans de Goede
2014-07-14 6:28 ` Mikko Perttunen
2014-07-14 13:36 ` Hans de Goede
2014-07-15 7:12 ` Mikko Perttunen
2014-07-15 8:55 ` Hans de Goede
2014-07-15 9:03 ` Mikko Perttunen
2014-07-15 9:31 ` Thierry Reding
2014-07-09 6:49 ` Thierry Reding
2014-07-09 13:45 ` Mikko Perttunen
2014-06-18 14:23 ` [PATCH v2 7/7] ARM: tegra: Add options for Tegra AHCI support to tegra_defconfig Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708132216.GA4979@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).