From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm64: Use include/asm-generic/io.h
Date: Fri, 11 Jul 2014 15:00:11 +0100 [thread overview]
Message-ID: <20140711140011.GA16321@arm.com> (raw)
In-Reply-To: <20140711130158.GA10827@ulmo>
On Fri, Jul 11, 2014 at 02:01:59PM +0100, Thierry Reding wrote:
> On Fri, Jul 11, 2014 at 02:58:09PM +0200, Arnd Bergmann wrote:
> > On Friday 11 July 2014, Catalin Marinas wrote:
> > > ioread32() is indeed an alias for readl on arm64 but if the address it
> > > gets as argument looks like an I/O port, it adds PCI_IOBASE (via the inl
> > > macro). This would no longer happen with Thierry's patches.
> > >
> > > So I guess that for this patch to work, we also need ioport_map() to
> > > return an address from the PCI_IOBASE range. Should we merge this now as
> > > well:
> > >
> > > http://linux-arm.org/git?p=linux-ld.git;a=commitdiff;h=3423064d8e42a38164a8436bcdf7434cf9cd2192
> >
> > This is also part of patch 1/3 in Thierry's series.
>
> The hunk in my patch 1/3 is missing the "& IO_SPACE_LIMIT", I can respin
> and include that.
OK, I missed this part. In which case, the patches look fine:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
(I'm also happy to merge 1 and 3, whatever you prefer)
next prev parent reply other threads:[~2014-07-11 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 15:11 [PATCH 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-09 15:11 ` [PATCH 2/3] ARM: Use include/asm-generic/io.h Thierry Reding
2014-07-09 15:11 ` [PATCH 3/3] arm64: " Thierry Reding
2014-07-10 11:00 ` Catalin Marinas
2014-07-10 13:14 ` Arnd Bergmann
2014-07-11 12:19 ` Catalin Marinas
2014-07-11 12:58 ` Arnd Bergmann
2014-07-11 13:01 ` Thierry Reding
2014-07-11 14:00 ` Catalin Marinas [this message]
2014-07-09 17:38 ` [PATCH 1/3] asm-generic/io.h: Implement generic {read,write}s*() Sam Ravnborg
2014-07-10 10:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711140011.GA16321@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).