From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] can: flexcan: add vf61x support for flexcan
Date: Mon, 14 Jul 2014 15:32:35 +0800 [thread overview]
Message-ID: <20140714073234.GD2197@dragon> (raw)
In-Reply-To: <cecd42e333cdf65ad512f719125f9180@agner.ch>
On Mon, Jul 14, 2014 at 09:06:33AM +0200, Stefan Agner wrote:
> Am 2014-07-14 08:04, schrieb Shawn Guo:
> > On Fri, Jul 11, 2014 at 03:58:37PM +0200, Stefan Agner wrote:
> >> >> @@ -362,7 +374,7 @@
> >> >>
> >> >> esdhc1: esdhc at 400b2000 {
> >> >> compatible = "fsl,imx53-esdhc";
> >> >> - reg = <0x400b2000 0x4000>;
> >> >> + reg = <0x400b2000 0x1000>;
> >> >
> >> > What's that doing here? :)
> >>
> >> That's an error I just stumbled upon.
> >
> > I do not see why it's an error. From Table 2-1. System Memory Map in
> > i.MX53 RM, the size of ESDHC1 is 16K.
> >
> > Shawn
>
> Hi Shawn,
>
> In the Vybrid RM memory map, 0x400B4000 is allocated to USB. 0x400B3000
> is empty, whereas for other peripherals (e.g. FlexCAN) which use
> multiple 0x1000 blocks, they are all explicitly stated. That is why I
> assumed 0x1000 is correct.
Ah, sorry. I thought you're on i.MX53. You're right about Vybrid, and
it should be 0x1000.
>
> But then, the memory map within the SDHC peripheral has some registers
> also located in 0x400B3000.
Really? Which one?
Shawn
> Hence I think 0x2000 is correct. Will send
> an updated and separated patch.
prev parent reply other threads:[~2014-07-14 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 10:52 [PATCH] can: flexcan: add vf61x support for flexcan Stefan Agner
2014-07-11 12:09 ` Marc Kleine-Budde
2014-07-11 13:58 ` Stefan Agner
2014-07-11 14:00 ` Lucas Stach
2014-07-11 17:53 ` Marc Kleine-Budde
2014-07-14 6:04 ` Shawn Guo
2014-07-14 7:06 ` Stefan Agner
2014-07-14 7:10 ` Stefan Agner
2014-07-14 7:32 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714073234.GD2197@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).