From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Thu, 17 Jul 2014 11:32:36 -0400 Subject: [PATCH] irqchip: gic: Fix core ID calculation when topology is read from DT In-Reply-To: <1405610624-18722-1-git-send-email-t.figa@samsung.com> References: <1405610624-18722-1-git-send-email-t.figa@samsung.com> Message-ID: <20140717153236.GS13108@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jul 17, 2014 at 05:23:44PM +0200, Tomasz Figa wrote: > Certain GIC implementation, namely those found on earlier, single > cluster, Exynos SoCs, have registers mapped without per-CPU banking, > which means that the driver needs to use different offset for each CPU. > > Currently the driver calculates the offset by multiplying value returned > by cpu_logical_map() by CPU offset parsed from DT. This is correct when > CPU topology is not specified in DT and aforementioned function returns > core ID alone. However when DT contains CPU topology, the function > changes to return cluster ID as well, which is non-zero on mentioned > SoCs and so breaks the calculation in GIC driver. > > This patch fixes this by masking out cluster ID in CPU offset > calculation so that only core ID is considered. Multi-cluster Exynos > SoCs already have banked GIC implementations, so this simple fix should > be enough. > > Reported-by: Lorenzo Pieralisi > Reported-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Tomasz Figa > --- > drivers/irqchip/irq-gic.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) iiuc, this was introduced by: db0d4db22a78d ARM: gic: allow GIC to support non-banked setups and so should be for v3.3 and up, correct? thx, Jason.