[PATCH 0/4 V3] irqchip: gic: Introduce ARM GICv2m MSI(-X) support

Mark Rutland
2014-07-18T09:02:05Z

On Thu, Jul 17, 2014 at 03:12:35PM +0100, Jason Cooper wrote:
> On Thu, Jul 17, 2014 at 02:55:34PM +0100, Mark Rutland wrote:
> > Hi Jason,
> >
> > On Thu, Jul 17, 2014 at 02:18:54PM +0100, Jason Cooper wrote:
> > > On Wed, Jul 09, 2014 at 06:05:00PM -0500, suravee.suthikulpanit at amd.com wrote:
> > > > From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> > > >
> > > > This patch set introduces support for MSI(-X) in GICv2m specification,
> > > > which is implemented in some variation of GIC400.
> > > >
> > > > This depends on and has been tested with the V7 of"Add support for PCI in AArch64"
> > > > (https://lkml.org/lkml/2014/3/14/320).
> > > >
> > > > Changes in V3:
> > > > * Rebase to git://git.infradead.org/users/jcooper/linux.git irqchip/gic
> > > > (per Jason Cooper request)
> > > > * Misc fix/clean up per Mark Rutland comments
> > > > * Minor Clean up in the driver/irqchip/irq-gic-v2m.c: alloc_msi_irqs()
> > > > * Patch 4 is new to the series:
> > > > * Add ARM64-specific version arch_setup_msi_irqs() to allow support
> > > > for Multiple MSI.
> > > > * Add support for Multiple MSI for GICv2m.
> > > >
> > > > Suravee Suthikulpanit (4):
> > > > irqchip: gic: Add binding probe for ARM GIC400
> > > > irqchip: gic: Restructuring ARM GIC code
> > > > irqchip: gic: Add supports for ARM GICv2m MSI(-X)
> > > > irqchip: gicv2m: Add support for multiple MSI for ARM64 GICv2m
> > >
> > > Ok, patch #1 applied to irqchip/urgent. Patches 2 and 3 applied to
> > > irqchip/gic with irqchip/urgent merged in. To facilitate
> > > testing/merging, I've prepared an unsigned tag for you on the
> > > irqchip/gic branch:
> >
> > I'm a little concerned that this is all going through for v3.17 without
> > a {Reviewed,Acked}-by from Marc or anyone working with GIC{,v2m}.
>
> Well, that's why it's not in irqchip/core yet. ;-) It can be undone if
> needed.

Ah, perhaps I was a litte premature. :)

> > While his comments on v1 have been addressed, he has not had a chance to
> > acknowledge the solutions. I appreciate Marc's holiday is unfortunately
> > timed.
> >
> > I also have an open concern with the binding with regard to the
> > orthogonality of GICV GICH and the MSI registers.
> >
> > Suravee, do you need this urgently for v3.17? I was under the impression
> > that we wouldn't have full PCIe support by then.
>
> If Suravee is ok with it, I can drop them for now and he can resend for
> v3.18. Since we've worked out a way to merge it all in one window, I
> don't think it would hurt anything to wait.

Ok.

> I'll leave these in irqchip/for-next until I hear from Suravee, then
> I'll drop the lot till we hear from Marc and look at the timing.

Keeping it in for-next for testing sounds like a good idea, but until we
hear from Marc I wouldn't want to see this queued for mainline. So the
above sounds fine to me.

Cheers,
Mark.