linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sam@ravnborg.org (Sam Ravnborg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*()
Date: Fri, 18 Jul 2014 23:06:31 +0200	[thread overview]
Message-ID: <20140718210631.GA22109@ravnborg.org> (raw)
In-Reply-To: <20140718205953.GA21964@ravnborg.org>

> 
> All these things are not introduced by your patch but now that
> you show some love and care for this file maybe we could take
> the next step and bring more order to the current semi chaos?

And I just noticed...

These are never used - and only defined a few places:
#define inb_p(addr)     inb(addr)
#define inw_p(addr)     inw(addr)
#define inl_p(addr)     inl(addr)
#define outb_p(x, addr) outb((x), (addr))
#define outw_p(x, addr) outw((x), (addr))
#define outl_p(x, addr) outl((x), (addr))

Likewise for these:
#define insb_p(port,to,len)     insb(port,to,len)
#define insw_p(port,to,len)     insw(port,to,len)
#define insl_p(port,to,len)     insl(port,to,len)

#define outsb_p(port,from,len)  outsb(port,from,len)
#define outsw_p(port,from,len)  outsw(port,from,len)
#define outsl_p(port,from,len)  outsl(port,from,len)



This set:
#define inb_p(addr)     inb(addr)
#define inw_p(addr)     inw(addr)
#define inl_p(addr)     inl(addr)
#define outb_p(x, addr) outb((x), (addr))
#define outw_p(x, addr) outw((x), (addr))
#define outl_p(x, addr) outl((x), (addr))

Should have a comment that say they are deprecated.
Especially the "b" variants still have many users.

	Sam

  reply	other threads:[~2014-07-18 21:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 11:01 [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-16 11:01 ` [PATCH v3 2/3] ARM: Use include/asm-generic/io.h Thierry Reding
2014-07-17 12:03   ` Catalin Marinas
2014-07-16 11:01 ` [PATCH v3 3/3] arm64: " Thierry Reding
2014-07-17 12:04   ` Catalin Marinas
2014-07-17 12:26     ` Thierry Reding
2014-07-18 15:50       ` Catalin Marinas
2014-07-17 12:01 ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Catalin Marinas
2014-07-18 20:59 ` Sam Ravnborg
2014-07-18 21:06   ` Sam Ravnborg [this message]
2014-07-19  7:38     ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read, write}s*() Arnd Bergmann
2014-07-19  8:41       ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Sam Ravnborg
2014-07-19  9:05         ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read, write}s*() Arnd Bergmann
2014-07-19  9:11           ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Sam Ravnborg
2014-07-19 17:21             ` James Bottomley
2014-08-05  9:07             ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read, write}s*() Geert Uytterhoeven
2014-08-05  9:14               ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Sam Ravnborg
2014-07-19  7:44   ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read, write}s*() Arnd Bergmann
2014-07-19  8:53     ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Sam Ravnborg
2014-07-19  9:10       ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read, write}s*() Arnd Bergmann
2014-07-19 12:59   ` [PATCH] asm-generic/io.h: reorder funtions to form logical groups Sam Ravnborg
2014-08-01 14:09     ` Thierry Reding
2014-08-01 22:42       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718210631.GA22109@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).