From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe()
Date: Sun, 20 Jul 2014 12:26:49 -0700 [thread overview]
Message-ID: <20140720192649.GA30124@quad.lixom.net> (raw)
In-Reply-To: <76576b662613369d0c71db30ceed4ed5ae1343d2.1405857442.git.viresh.kumar@linaro.org>
On Sun, Jul 20, 2014 at 05:29:47PM +0530, Viresh Kumar wrote:
> Following compilation warning occurs when compiled with:
> CONFIG_DEBUG_SECTION_MISMATCH=y
>
> WARNING: drivers/pci/host/built-in.o(.data+0xc0): Section mismatch in
> reference from the variable spear13xx_pcie_driver to the function
> .init.text:spear13xx_pcie_probe()
>
> Both .probe() and pcie_init() are marked with __init, but spear13xx_pcie_driver
> isn't. And so section mismatch.
>
> Fix it by marking spear13xx_pcie_driver with __initdata.
>
> Fixes: 51b66a6 (PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx)
Please use 12 significant digits, since 7 might not be sufficient later
on in time. I've fixed it up here.
> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Olof/Arnd,
>
> Let me know if a PULL request is required for this, otherwise just apply them
> directly.
I've applied both of these on top of next/drivers, where your previous branch
was. No need for a pull request.
-Olof
next prev parent reply other threads:[~2014-07-20 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 11:59 [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe() Viresh Kumar
2014-07-20 11:59 ` [PATCH 2/2] PCI: spear: Remove spear13xx_pcie_remove() Viresh Kumar
2014-07-20 19:26 ` Olof Johansson [this message]
2014-07-21 0:12 ` [PATCH 1/2] PCI: spear: Fix Section mismatch compilation warning for probe() Viresh Kumar
2014-07-21 0:21 ` Olof Johansson
2014-07-21 0:27 ` Viresh Kumar
2014-07-21 2:15 ` Rob Herring
2014-07-21 4:28 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140720192649.GA30124@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox