linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure
Date: Mon, 21 Jul 2014 04:09:02 -0700	[thread overview]
Message-ID: <20140721110902.GY18374@atomide.com> (raw)
In-Reply-To: <1398216429-4681-7-git-send-email-joelf@ti.com>

* Joel Fernandes <joelf@ti.com> [140422 18:27]:
> oh->name is no longer used, correct the error message.

I guess this error is created by one of the patchs in this
series? So maybe fold it into the patch creating this error?

Regards,

Tony
 
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
>  arch/arm/mach-omap2/timer.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index 4fcfd7a..519ccfd 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -331,8 +331,8 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
>  	if (clk_get_parent(timer->fclk) != src) {
>  		r = clk_set_parent(timer->fclk, src);
>  		if (r < 0) {
> -			pr_warn("%s: %s cannot set source\n", __func__,
> -				oh->name);
> +			pr_warn("%s: cannot set timer's source\n", __func__);
> +			WARN_ON(1);
>  			clk_put(src);
>  			return r;
>  		}
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2014-07-21 11:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23  1:27 [PATCH 0/8] OMAP2+ system timer cleanup series Joel Fernandes
2014-04-23  1:27 ` [PATCH 1/8] ARM: OMAP2+: timer: Add a powerup function Joel Fernandes
2014-07-21 11:00   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name setting Joel Fernandes
2014-07-21 11:05   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 3/8] ARM: OMAP2+: timer: Add comment on timer clk parenting Joel Fernandes
2014-07-21 11:07   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 4/8] ARM: OMAP2+: timer: Remove hwmod look-up dependency for DT-boot Joel Fernandes
2014-04-23  1:27 ` [PATCH 5/8] ARM: OMAP2+: timer: Use of_clk_get for DT platforms Joel Fernandes
2014-04-23  1:27 ` [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure Joel Fernandes
2014-07-21 11:09   ` Tony Lindgren [this message]
2014-04-23  1:27 ` [PATCH 7/8] ARM: OMAP2+: timer: Add fallback for of_clk_get Joel Fernandes
2014-07-21 11:10   ` Tony Lindgren
2014-04-23  1:27 ` [PATCH 8/8] ARM: OMAP2+: timer: Add legacy code for old way of getting fclk Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721110902.GY18374@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).