From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mtd: atmel_nand: make ecc parameters same as definition
Date: Mon, 21 Jul 2014 19:56:03 -0700 [thread overview]
Message-ID: <20140722025603.GC7537@ld-irv-0074> (raw)
In-Reply-To: <1402559925-20910-1-git-send-email-voice.shen@atmel.com>
On Thu, Jun 12, 2014 at 03:58:45PM +0800, Bo Shen wrote:
> If the ecc parameter is not the same as definition, when the
> mtd core check these parameters, it will give the error result.
>
> Take the following as an example:
>
> Calculate how many bits can be corrected in one page.
> According to the ecc parameters definition,
>
> one page correct bits = (mtd->writesize * ecc->strength) / ecc->size
>
> take the following use case as an example:
> mtd->writesize = 2048 bytes
> ecc->strength = 4 bytes (for 512 bytes)
>
> before this patch, the ecc->size = 2048, so the result is 4 bytes.
> after this patch, the ecc->size = 512, so the result is 16 bytes.
>
> So, align the ecc parameters the same as definition to correct
> this kind of error.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> Acked-by: Josh Wu <josh.wu@atmel.com>
> ---
> Changes in v2:
> - Enhancement the commit message.
Pushed to l2-mtd.git. Thanks!
Brian
prev parent reply other threads:[~2014-07-22 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 7:58 [PATCH v2] mtd: atmel_nand: make ecc parameters same as definition Bo Shen
2014-07-22 2:56 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722025603.GC7537@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox