From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: remove remaining definitions of PLAT_PHYS_OFFSET from <mach/memory.h>
Date: Fri, 25 Jul 2014 11:09:12 +0200 [thread overview]
Message-ID: <20140725090912.GC6146@pengutronix.de> (raw)
In-Reply-To: <20140725000621.GO21766@n2100.arm.linux.org.uk>
Hello Russell,
On Fri, Jul 25, 2014 at 01:06:22AM +0100, Russell King - ARM Linux wrote:
> On Mon, Jul 07, 2014 at 09:13:05AM +0200, Uwe Kleine-K?nig wrote:
> > The platforms selecting NEED_MACH_MEMORY_H defined the start address of
> > their physical memory in the respective <mach/memory.h>. With
> > ARM_PATCH_PHYS_VIRT=y (which is quite common today) this is useless
> > though because the definition isn't used but determined dynamically.
> >
> > So remove the definitions from all <mach/memory.h> and provide the
> > Kconfig symbol PHYS_OFFSET with the respective defaults in case
> > ARM_PATCH_PHYS_VIRT isn't enabled.
> >
> > This allows to drop the dependency of PHYS_OFFSET on !NEED_MACH_MEMORY_H
> > which prevents compiling an integrator nommu-kernel.
> > (CONFIG_PAGE_OFFSET which has "default PHYS_OFFSET if !MMU" expanded to
> > "0x" because CONFIG_PHYS_OFFSET doesn't exist as INTEGRATOR selects
> > NEED_MACH_MEMORY_H.)
>
> Should I assume that this hasn't been build tested?
darn, I admit being guilty not retesting it after rebasing to 3.16-rc. I
think I did test it when I wrote the patch the first time, but you made
me unsure if I tested all relevant cases. Working on a follow-up patch.
Mea culpa
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-07-25 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 9:57 [PATCH 1/3] ARM: exynos: remove unused <mach/memory.h> Uwe Kleine-König
2014-07-02 9:57 ` [PATCH 2/3] ARM: remove remaining definitions of PLAT_PHYS_OFFSET from <mach/memory.h> Uwe Kleine-König
2014-07-02 10:38 ` Russell King - ARM Linux
2014-07-02 16:15 ` Uwe Kleine-König
2014-07-02 16:18 ` Russell King - ARM Linux
2014-07-07 7:13 ` [PATCH v2 " Uwe Kleine-König
2014-07-25 0:06 ` Russell King - ARM Linux
2014-07-25 9:09 ` Uwe Kleine-König [this message]
2014-07-25 12:21 ` Uwe Kleine-König
2014-07-02 9:57 ` [PATCH 3/3] ARM: only select ARM_PATCH_PHYS_VIRT if MMU is enabled Uwe Kleine-König
2014-07-02 10:35 ` Russell King - ARM Linux
2014-07-07 6:51 ` Uwe Kleine-König
2014-07-08 11:47 ` [PATCH 1/3] ARM: exynos: remove unused <mach/memory.h> Tomasz Figa
2014-07-08 15:20 ` Sachin Kamat
2014-07-22 7:51 ` Uwe Kleine-König
2014-07-22 16:14 ` Olof Johansson
2014-07-22 23:37 ` Kukjin Kim
2014-07-23 19:58 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725090912.GC6146@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).