From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 8/8] ARM: sun7i: Add mod1 clock nodes
Date: Mon, 28 Jul 2014 15:25:24 +0200 [thread overview]
Message-ID: <20140728132524.GM3952@lukather> (raw)
In-Reply-To: <1406519386-4902-9-git-send-email-emilio@elopez.com.ar>
On Mon, Jul 28, 2014 at 12:49:46AM -0300, Emilio L?pez wrote:
> This commit adds all the mod1 clocks available on A20 to its device
> tree. This list was created by looking at the A20 user manual.
>
> Not-signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
> ---
>
> As mentioned on an earlier patch, note that this is untested, and I
> only added them to sun7i. It'd be great if actual users of these clocks
> could comment :)
>
> arch/arm/boot/dts/sun7i-a20.dtsi | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 5d0265a..c57f7ad 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -335,6 +335,29 @@
> clock-output-names = "ir1";
> };
>
> + iis0_clk: clk at 01c200b8 {
> + #clock-cells = <0>;
> + compatible = "allwinner,sun4i-a10-mod1-clk";
> + reg = <0x01c200b8 0x4>;
> + clocks = <&pll2 0>, <&pll2 1>, <&pll2 2>, <&pll2 3>;
> + clock-output-names = "iis0";
Usually, it's called i2s.
Otherwise, beside Chen-Yu's comment, it looks fine.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140728/f025e41c/attachment.sig>
next prev parent reply other threads:[~2014-07-28 13:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 3:49 [RFC 0/8] Audio clocks for sun[457]i, SoC revision detection Emilio López
2014-07-28 3:49 ` [RFC 1/8] clk: sunxi: PLL2 support for sun4i, sun5i and sun7i Emilio López
2014-07-28 3:49 ` [RFC 2/8] clk: sunxi: codec clock support Emilio López
2014-07-28 13:19 ` Maxime Ripard
2014-07-28 3:49 ` [RFC 3/8] clk: sunxi: mod1 " Emilio López
2014-07-28 3:49 ` [RFC 4/8] clk: sunxi: add __iomem markings to MMIO pointers Emilio López
2014-07-28 13:21 ` Maxime Ripard
2014-07-28 22:42 ` Mike Turquette
2014-07-28 3:49 ` [RFC 5/8] clk: sunxi: staticize structures and arrays Emilio López
2014-07-28 13:21 ` Maxime Ripard
2014-07-28 3:49 ` [RFC 6/8] ARM: sunxi: Add PLL2 support Emilio López
2014-07-28 13:22 ` Maxime Ripard
2014-07-28 3:49 ` [RFC 7/8] ARM: sunxi: Add codec clock support Emilio López
2014-07-28 3:49 ` [RFC 8/8] ARM: sun7i: Add mod1 clock nodes Emilio López
2014-07-28 4:28 ` Chen-Yu Tsai
2014-07-28 14:51 ` jonsmirl at gmail.com
2014-07-28 13:25 ` Maxime Ripard [this message]
2014-07-28 14:47 ` jonsmirl at gmail.com
2014-07-31 10:19 ` Maxime Ripard
2014-07-28 12:42 ` [RFC 0/8] Audio clocks for sun[457]i, SoC revision detection Maxime Ripard
2014-07-28 14:40 ` jonsmirl at gmail.com
2014-07-31 10:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728132524.GM3952@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox