[PATCH 30/35] irqchip: add irq-omap-intc.h header

Tony Lindgren
2014-07-29T15:06:55Z

* Felipe Balbi <balbi@ti.com> [140729 07:13]:
> On Tue, Jul 29, 2014 at 05:01:33AM -0700, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [140728 14:19]:
> > > OMAP INTC irqchip driver will be moved under
> > > drivers/irqchip/ soon but we still have a dependency
> > > with mach-omap2 when it comes to idle functions.
> > >
> > > In order to make it easy to share those function
> > > prototypes with OMAP PM code, we introduce this new
> > > header.
> > >
> > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > ---
> > > arch/arm/mach-omap2/board-3430sdp.c | 1 +
> > > arch/arm/mach-omap2/board-am3517crane.c | 1 +
> > > arch/arm/mach-omap2/board-am3517evm.c | 1 +
> > > arch/arm/mach-omap2/board-cm-t35.c | 1 +
> > > arch/arm/mach-omap2/board-cm-t3517.c | 1 +
> > > arch/arm/mach-omap2/board-devkit8000.c | 1 +
> > > arch/arm/mach-omap2/board-ldp.c | 1 +
> > > arch/arm/mach-omap2/board-omap3beagle.c | 1 +
> > > arch/arm/mach-omap2/board-omap3logic.c | 1 +
> > > arch/arm/mach-omap2/board-omap3pandora.c | 1 +
> > > arch/arm/mach-omap2/board-omap3stalker.c | 1 +
> > > arch/arm/mach-omap2/board-omap3touchbook.c | 1 +
> > > arch/arm/mach-omap2/board-overo.c | 1 +
> > > arch/arm/mach-omap2/board-rx51.c | 1 +
> > > arch/arm/mach-omap2/board-ti8168evm.c | 1 +
> > > arch/arm/mach-omap2/common.h | 9 ---------
> > > arch/arm/mach-omap2/cpuidle34xx.c | 1 +
> > > arch/arm/mach-omap2/irq.c | 1 +
> > > arch/arm/mach-omap2/pm24xx.c | 1 +
> > > arch/arm/mach-omap2/pm34xx.c | 1 +
> > > include/linux/irqchip/irq-omap-intc.h | 32 ++++++++++++++++++++++++++++++
> > ...
> >
> > > +void omap2_init_irq(void);
> > > +void omap3_init_irq(void);
> > > +void ti81xx_init_irq(void);
> >
> > I think these will all go away with DT based booting?
> > So it might be worth waiting for that rather than churn
> > all these files, or..
>
> you just asked me to rebase this series because now we had OMAP3 idle
> working with DT. And now, you're asking me to hold on to this series
> because not everything is DT-based yet.

I just don't like the idea of patching all these board files that
are going away anyways. If we need to do that, let's just add it
to common.h that's already included by all the remaining board-*.c
files. I know we should rather include the files directly, but in
this case that's just extra churn.

The real problem is how to properly deal with the save and
restore calls that idle code needs.

In any case, it seems we can merge quite a bit of this series
already and then deal with the problem parts.

> This is the third time I rebase the series after a long hiatus and it
> always comes out to the same result -> "let's wait some more".

Nope, it's always been "this series causes PM regressions"
and few other minor comments. And we have not been in any
position to really test that until with v3.16-rc4. And then
you always run out of time and nobody else does anything :)

Regards,

Tony